From 6bfdebb412d87890c9c727a5975aed9cda66bf33 Mon Sep 17 00:00:00 2001 From: "David L. Jones" Date: Tue, 15 Oct 2019 04:32:07 +0000 Subject: Revert [SROA] Reuse existing lifetime markers if possible This reverts r374692 (git commit 92694eba933ef4ea0b1b6377809ff266df37d61b) Reproducer sent to commit thread on llvm-commits. llvm-svn: 374859 --- llvm/lib/Transforms/Scalar/SROA.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'llvm/lib/Transforms') diff --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp index a36b3c50ea3..4b816832c31 100644 --- a/llvm/lib/Transforms/Scalar/SROA.cpp +++ b/llvm/lib/Transforms/Scalar/SROA.cpp @@ -3072,13 +3072,6 @@ private: LLVM_DEBUG(dbgs() << " original: " << II << "\n"); assert(II.getArgOperand(1) == OldPtr); - bool EntireRange = (NewBeginOffset == NewAllocaBeginOffset && - NewEndOffset == NewAllocaEndOffset); - - // If the new lifetime marker would not differ from the old, just keep it. - if (&OldAI == &NewAI && EntireRange) - return true; - // Record this instruction for deletion. Pass.DeadInsts.insert(&II); @@ -3089,7 +3082,8 @@ private: // promoted, but PromoteMemToReg doesn't handle that case.) // FIXME: Check whether the alloca is promotable before dropping the // lifetime intrinsics? - if (!EntireRange) + if (NewBeginOffset != NewAllocaBeginOffset || + NewEndOffset != NewAllocaEndOffset) return true; ConstantInt *Size = -- cgit v1.2.3