summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Target
diff options
context:
space:
mode:
authorKai Luo <lkail@cn.ibm.com>2019-08-02 03:14:17 +0000
committerKai Luo <lkail@cn.ibm.com>2019-08-02 03:14:17 +0000
commitfec7da8285b1e41fcf524c42f389f1cd87a2690f (patch)
treed3f39857549782e4c96c0d49c88e06c25159e126 /llvm/lib/Target
parent038dd43782b0ecaf988f0420dc6331b06bb77958 (diff)
downloadbcm5719-llvm-fec7da8285b1e41fcf524c42f389f1cd87a2690f.tar.gz
bcm5719-llvm-fec7da8285b1e41fcf524c42f389f1cd87a2690f.zip
[PowerPC][Peephole] Check if `extsw`'s second operand is a virtual register
Summary: When combining `extsw` and `sldi` in `PPCMIPeephole`, we have to check if `extsw`'s second operand is a virtual register, otherwise we might get miscompile. Differential Revision: https://reviews.llvm.org/D65315 llvm-svn: 367645
Diffstat (limited to 'llvm/lib/Target')
-rw-r--r--llvm/lib/Target/PowerPC/PPCMIPeephole.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/llvm/lib/Target/PowerPC/PPCMIPeephole.cpp b/llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
index 1b48bbaf1f4..fe4f351e639 100644
--- a/llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
+++ b/llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
@@ -1426,6 +1426,12 @@ bool PPCMIPeephole::combineSEXTAndSHL(MachineInstr &MI,
if (!MRI->hasOneNonDBGUse(SrcReg))
return false;
+ assert(SrcMI->getNumOperands() == 2 && "EXTSW should have 2 operands");
+ assert(SrcMI->getOperand(1).isReg() &&
+ "EXTSW's second operand should be a register");
+ if (!Register::isVirtualRegister(SrcMI->getOperand(1).getReg()))
+ return false;
+
LLVM_DEBUG(dbgs() << "Combining pair: ");
LLVM_DEBUG(SrcMI->dump());
LLVM_DEBUG(MI.dump());
OpenPOWER on IntegriCloud