diff options
author | Andrew Wilkins <axwalk@gmail.com> | 2015-09-05 08:27:33 +0000 |
---|---|---|
committer | Andrew Wilkins <axwalk@gmail.com> | 2015-09-05 08:27:33 +0000 |
commit | bb6d95fc3a74eab118b622e4c779d0b9edc53f54 (patch) | |
tree | c991238155de0d4d408287bf1efd7cfcaed7bd8b /llvm/lib/Target | |
parent | 6f73008506ec923ff69309016fd28cb6121eb11d (diff) | |
download | bcm5719-llvm-bb6d95fc3a74eab118b622e4c779d0b9edc53f54.tar.gz bcm5719-llvm-bb6d95fc3a74eab118b622e4c779d0b9edc53f54.zip |
[cmake] rework LLVM_LINK_LLVM_DYLIB option handling
Summary:
This diff attempts to address the concerns raised in
http://reviews.llvm.org/D12488.
We introduce a new USE_SHARED option to llvm_config,
which, if set, causes the target to be linked against
libLLVM.
add_llvm_utility now uniformly disables linking against
libLLVM. These utilities are not intended for distribution,
and this keeps the option handling more centralised.
llvm-shlib is now processes before any other "tools"
subdirectories, ensuring the libLLVM target is defined
before its dependents.
One main difference from what was requested: llvm_config
does not prune LLVM_DYLIB_COMPONENTS from the components
passed into explicit_llvm_config. This is because the "all"
component does something special, adding additional
libraries (namely libLTO). Adding the component libraries
after libLLVM should not be a problem, as symbols will be
resolved in libLLVM first.
Finally, I'm not really happy with the
DISABLE_LLVM_LINK_LLVM option, but I'm not sure of a
better way to get the following:
- link all tools and shared libraries to libLLVM if
LLVM_LINK_LLVM_DYLIB is set
- some way of explicitly *not* doing so for utilities
and libLLVM itself
Suggestions for improvement here are particularly welcome.
Reviewers: beanz
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D12590
llvm-svn: 246918
Diffstat (limited to 'llvm/lib/Target')
0 files changed, 0 insertions, 0 deletions