diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2015-02-12 23:26:26 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2015-02-12 23:26:26 +0000 |
| commit | a12fcb790fb3694c6fcdf14047be72283ae4a0ee (patch) | |
| tree | 2d36573e75057d467111d8e538ab8b48e9502b92 /llvm/lib/Target | |
| parent | 8807e830373233ac31be4bf4ddbe6e854e8ebae5 (diff) | |
| download | bcm5719-llvm-a12fcb790fb3694c6fcdf14047be72283ae4a0ee.tar.gz bcm5719-llvm-a12fcb790fb3694c6fcdf14047be72283ae4a0ee.zip | |
X86: Don't crash if we can't decode the pshufb mask
Constant pool entries are uniqued by their contents regardless of their
type. This means that a pshufb can have a shuffle mask which isn't a
simple array of bytes.
The code path which attempts to decode the mask didn't check for
failure, causing PR22559.
llvm-svn: 228979
Diffstat (limited to 'llvm/lib/Target')
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index c11c8e3febd..3c2e27af8f2 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -5480,6 +5480,8 @@ static bool getTargetShuffleMask(SDNode *N, MVT VT, if (auto *C = dyn_cast<Constant>(MaskCP->getConstVal())) { DecodePSHUFBMask(C, Mask); + if (Mask.empty()) + return false; break; } |

