diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2019-05-13 16:02:45 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2019-05-13 16:02:45 +0000 |
| commit | cf5a8eb7cd3a9c90f5667f146350cf0d0c1489bb (patch) | |
| tree | f775fac9e9e360ed600aefbc497aed2d34d07658 /llvm/lib/Target/X86 | |
| parent | 4e21c770ec328bf03fac6f729602a744b7ef4bca (diff) | |
| download | bcm5719-llvm-cf5a8eb7cd3a9c90f5667f146350cf0d0c1489bb.tar.gz bcm5719-llvm-cf5a8eb7cd3a9c90f5667f146350cf0d0c1489bb.zip | |
[X86][SSE] Relax use limits for lowerAddSubToHorizontalOp (PR32433)
Now that we can use HADD/SUB for scalar additions from any pair of extracted elements (D61263), we can relax the one use limit as we will be able to merge multiple uses into using the same HADD/SUB op.
This exposes a couple of missed opportunities in LowerBuildVectorv4x32 which will be committed separately.
Differential Revision: https://reviews.llvm.org/D61782
llvm-svn: 360594
Diffstat (limited to 'llvm/lib/Target/X86')
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 58815524b0a..d4c2b108537 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -19033,16 +19033,11 @@ static SDValue lowerAddSubToHorizontalOp(SDValue Op, SelectionDAG &DAG, if (!IsFP && !Subtarget.hasSSSE3()) return Op; - // Defer forming the minimal horizontal op if the vector source has more than - // the 2 extract element uses that we're matching here. In that case, we might - // form a horizontal op that includes more than 1 add/sub op. + // Extract from a common vector. if (LHS.getOpcode() != ISD::EXTRACT_VECTOR_ELT || RHS.getOpcode() != ISD::EXTRACT_VECTOR_ELT || LHS.getOperand(0) != RHS.getOperand(0) || - !LHS.getOperand(0)->hasNUsesOfValue(2, 0)) - return Op; - - if (!isa<ConstantSDNode>(LHS.getOperand(1)) || + !isa<ConstantSDNode>(LHS.getOperand(1)) || !isa<ConstantSDNode>(RHS.getOperand(1)) || !shouldUseHorizontalOp(true, DAG, Subtarget)) return Op; |

