diff options
| author | Evan Cheng <evan.cheng@apple.com> | 2008-12-05 01:06:39 +0000 |
|---|---|---|
| committer | Evan Cheng <evan.cheng@apple.com> | 2008-12-05 01:06:39 +0000 |
| commit | 2a03c7e977b7a7bd923c8f8c41c0e81e3b96f63e (patch) | |
| tree | b04c06f8152f3ad50cf9a947732418d8097e3477 /llvm/lib/Target/X86/X86Subtarget.cpp | |
| parent | d368de794af01b50d269306649f02128e4fbbbea (diff) | |
| download | bcm5719-llvm-2a03c7e977b7a7bd923c8f8c41c0e81e3b96f63e.tar.gz bcm5719-llvm-2a03c7e977b7a7bd923c8f8c41c0e81e3b96f63e.zip | |
Re-did 60519. It turns out Darwin's handling of hidden visibility symbols are a bit more complicate than I expected. Both declarations and weak definitions still need a stub indirection. However, the stubs are in data section and they contain the addresses of the actual symbols.
llvm-svn: 60571
Diffstat (limited to 'llvm/lib/Target/X86/X86Subtarget.cpp')
| -rw-r--r-- | llvm/lib/Target/X86/X86Subtarget.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/llvm/lib/Target/X86/X86Subtarget.cpp b/llvm/lib/Target/X86/X86Subtarget.cpp index c17f2dc6825..b836471afc1 100644 --- a/llvm/lib/Target/X86/X86Subtarget.cpp +++ b/llvm/lib/Target/X86/X86Subtarget.cpp @@ -40,10 +40,14 @@ bool X86Subtarget::GVRequiresExtraLoad(const GlobalValue* GV, if (TM.getRelocationModel() != Reloc::Static && TM.getCodeModel() != CodeModel::Large) { if (isTargetDarwin()) { - return (!isDirectCall && - (GV->hasWeakLinkage() || GV->hasLinkOnceLinkage() || - GV->hasCommonLinkage() || - (GV->isDeclaration() && !GV->hasNotBeenReadFromBitcode()))); + bool isDecl = GV->isDeclaration() && !GV->hasNotBeenReadFromBitcode(); + if (GV->hasHiddenVisibility() && + (Is64Bit || (!isDecl && !GV->hasCommonLinkage()))) + // If symbol visibility is hidden, the extra load is not needed if + // target is x86-64 or the symbol is definitely defined in the current + // translation unit. + return false; + return !isDirectCall && (isDecl || GV->mayBeOverridden()); } else if (isTargetELF()) { // Extra load is needed for all externally visible. if (isDirectCall) |
