diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2014-08-02 11:34:23 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2014-08-02 11:34:23 +0000 |
| commit | 16c13cad353cc3a5ba85b2173e39266a3d425101 (patch) | |
| tree | bcafec3c5e3973d6c142b288d70aa017aad99004 /llvm/lib/Target/X86/X86ISelLowering.cpp | |
| parent | bec57b406d174575858b88fee5cc53a846e25758 (diff) | |
| download | bcm5719-llvm-16c13cad353cc3a5ba85b2173e39266a3d425101.tar.gz bcm5719-llvm-16c13cad353cc3a5ba85b2173e39266a3d425101.zip | |
[x86] Remove the FIXME that was implemented in r214628. Managed to
forget to update the comment here... =/
llvm-svn: 214630
Diffstat (limited to 'llvm/lib/Target/X86/X86ISelLowering.cpp')
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index eb722daef7f..5ae752c1da5 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -18945,10 +18945,6 @@ static bool combineX86ShuffleChain(SDValue Op, SDValue Root, ArrayRef<int> Mask, /// This should never be an issue in practice as the shuffle lowering doesn't /// produce sequences of more than 8 instructions. /// -/// FIXME: Currently, we don't collapse instructions *into* PSHUFB. We should, -/// and we should do so more aggressively than we form PSHUFB because once we -/// have a PSHUFB, we might as well do as much shuffling as we can. -/// /// FIXME: We will currently miss some cases where the redundant shuffling /// would simplify under the threshold for PSHUFB formation because of /// combine-ordering. To fix this, we should do the redundant instruction |
