diff options
| author | Oliver Stannard <oliver.stannard@arm.com> | 2017-12-04 13:42:22 +0000 |
|---|---|---|
| committer | Oliver Stannard <oliver.stannard@arm.com> | 2017-12-04 13:42:22 +0000 |
| commit | 7ab60605f8e7284f1b1f2e2076ad8061d0970e11 (patch) | |
| tree | 4629503749b329cd91a600c5677e15e4e16f1155 /llvm/lib/Target/ARM/AsmParser | |
| parent | fd9a526a30cdb84ee9821e384cf13ec1dccdaf7e (diff) | |
| download | bcm5719-llvm-7ab60605f8e7284f1b1f2e2076ad8061d0970e11.tar.gz bcm5719-llvm-7ab60605f8e7284f1b1f2e2076ad8061d0970e11.zip | |
Revert r319649 - [Asm, ARM] Add fallback diag for multiple invalid operands
This is causing a failure in the llvm-clang-x86_64-expensive-checks-win
buildbot, and I can't reproduce it locally, so reverting until I can work out
what is wrong.
llvm-svn: 319654
Diffstat (limited to 'llvm/lib/Target/ARM/AsmParser')
| -rw-r--r-- | llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index ddef2c99a0c..26fda5f22b4 100644 --- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -10134,7 +10134,6 @@ ARMAsmParser::FilterNearMisses(SmallVectorImpl<NearMissInfo> &NearMissesIn, std::multimap<unsigned, unsigned> OperandMissesSeen; SmallSet<uint64_t, 4> FeatureMissesSeen; bool ReportedTooFewOperands = false; - bool HaveMultipleBadOperands = false; // Process the near-misses in reverse order, so that we see more general ones // first, and so can avoid emitting more specific ones. @@ -10254,12 +10253,6 @@ ARMAsmParser::FilterNearMisses(SmallVectorImpl<NearMissInfo> &NearMissesIn, NearMissesOut.emplace_back(Message); break; } - case NearMissInfo::NearMissMultipleOperands: { - // Just record the fact that we have seen this, we will use it as a - // fall-back if we don't find a better operand error to report. - HaveMultipleBadOperands = true; - break; - } case NearMissInfo::NearMissTooFewOperands: { if (!ReportedTooFewOperands) { SMLoc EndLoc = ((ARMOperand &)*Operands.back()).getEndLoc(); @@ -10275,16 +10268,6 @@ ARMAsmParser::FilterNearMisses(SmallVectorImpl<NearMissInfo> &NearMissesIn, break; } } - - // If there is an encoding that missed on multiple operands (but matched the - // target features and early predicate), but we haven't been able to emit a - // more specific error for any operands, emit a generic error. This lets the - // user know that the mnemonic exists, and that some combination of operands - // would work for the current target. - if (HaveMultipleBadOperands && NearMissesOut.empty()) { - NearMissesOut.emplace_back(NearMissMessage{ - IDLoc, StringRef("invalid operands for instruction")}); - } } void ARMAsmParser::ReportNearMisses(SmallVectorImpl<NearMissInfo> &NearMisses, |

