summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
diff options
context:
space:
mode:
authorChad Rosier <mcrosier@codeaurora.org>2016-11-11 19:52:45 +0000
committerChad Rosier <mcrosier@codeaurora.org>2016-11-11 19:52:45 +0000
commit8ade03463e3cf09b9169cd913384d7385fdeb226 (patch)
tree5a42aa6c4962341700a65e0464f93bcbc56b35bf /llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
parent6de481a3786b5b0409eddeee4b99a148e3f0f3f3 (diff)
downloadbcm5719-llvm-8ade03463e3cf09b9169cd913384d7385fdeb226.tar.gz
bcm5719-llvm-8ade03463e3cf09b9169cd913384d7385fdeb226.zip
[AArch64] Update a FIXME comment to reflect current state. NFC.
llvm-svn: 286625
Diffstat (limited to 'llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp')
-rw-r--r--llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp b/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
index fc5ed6e9c8c..7aed5d65600 100644
--- a/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
+++ b/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
@@ -1706,8 +1706,10 @@ bool AArch64LoadStoreOpt::runOnMachineFunction(MachineFunction &Fn) {
return Modified;
}
-// FIXME: Do we need/want a pre-alloc pass like ARM has to try to keep
-// loads and stores near one another?
+// FIXME: Do we need/want a pre-alloc pass like ARM has to try to keep loads and
+// stores near one another? Note: The pre-RA instruction scheduler already has
+// hooks to try and schedule pairable loads/stores together to improve pairing
+// opportunities. Thus, pre-RA pairing pass may not be worth the effort.
// FIXME: When pairing store instructions it's very possible for this pass to
// hoist a store with a KILL marker above another use (without a KILL marker).
OpenPOWER on IntegriCloud