diff options
| author | George Rimar <grimar@accesssoftek.com> | 2019-09-02 14:57:35 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2019-09-02 14:57:35 +0000 |
| commit | 78e8011a29d8c38af35da8e74c9d9ceaf2b0d1dd (patch) | |
| tree | 9d1e32ccb2781ac18f963b786fdb95b0312b3060 /llvm/lib/Object/ObjectFile.cpp | |
| parent | 4e54cf3e0e71b38b2fde1a815e8460b14026762a (diff) | |
| download | bcm5719-llvm-78e8011a29d8c38af35da8e74c9d9ceaf2b0d1dd.tar.gz bcm5719-llvm-78e8011a29d8c38af35da8e74c9d9ceaf2b0d1dd.zip | |
Recommit r370661 "[llvm-nm] - Add a test case for case when we dump a symbol that belongs to a section with a broken sh_name."
Fix: add a 'consumeError()' call to ObjectFile.cpp.
This error was never checked.
Original commit message:
It adds a test case for a problem fixed by D66976 <https://reviews.llvm.org/D66976>.
It was introduced by me in D66089 <https://reviews.llvm.org/D66089>.
The error reported was never consumed because of a wrong variable name used,
so it could fail when LLVM_ENABLE_ABI_BREAKING_CHECKS is used.
Differential revision: https://reviews.llvm.org/D67002
llvm-svn: 370669
Diffstat (limited to 'llvm/lib/Object/ObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/ObjectFile.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/Object/ObjectFile.cpp b/llvm/lib/Object/ObjectFile.cpp index 79812e3a10b..bcc44cd6ce3 100644 --- a/llvm/lib/Object/ObjectFile.cpp +++ b/llvm/lib/Object/ObjectFile.cpp @@ -67,8 +67,10 @@ Error ObjectFile::printSymbolName(raw_ostream &OS, DataRefImpl Symb) const { uint32_t ObjectFile::getSymbolAlignment(DataRefImpl DRI) const { return 0; } bool ObjectFile::isSectionBitcode(DataRefImpl Sec) const { - if (Expected<StringRef> NameOrErr = getSectionName(Sec)) + Expected<StringRef> NameOrErr = getSectionName(Sec); + if (NameOrErr) return *NameOrErr == ".llvmbc"; + consumeError(NameOrErr.takeError()); return false; } |
