diff options
| author | Nirav Dave <niravd@google.com> | 2018-06-20 15:36:29 +0000 |
|---|---|---|
| committer | Nirav Dave <niravd@google.com> | 2018-06-20 15:36:29 +0000 |
| commit | cd558887d3b17f99ad86605003a1e7c0e689a863 (patch) | |
| tree | d07da9bbe4605ef87d10e1f1f6de97cedb112f6a /llvm/lib/CodeGen/SelectionDAG | |
| parent | da873b5e2ed165caeb117175b3618c1be60aae3b (diff) | |
| download | bcm5719-llvm-cd558887d3b17f99ad86605003a1e7c0e689a863.tar.gz bcm5719-llvm-cd558887d3b17f99ad86605003a1e7c0e689a863.zip | |
[DAG] Fix and-mask folding when narrowing loads.
Summary:
Check that and masks are strictly smaller than implicit mask from
narrowed load.
Fixes PR37820.
Reviewers: samparker, RKSimon, nemanjai
Subscribers: hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D48335
llvm-svn: 335137
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 3d835266b90..ee767c0fd03 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -8688,8 +8688,9 @@ SDValue DAGCombiner::ReduceLoadWidth(SDNode *N) { if (ShiftMask.isMask()) { EVT MaskedVT = EVT::getIntegerVT(*DAG.getContext(), ShiftMask.countTrailingOnes()); - // Recompute the type. - if (TLI.isLoadExtLegal(ExtType, N0.getValueType(), MaskedVT)) + // If the mask is smaller, recompute the type. + if ((ExtVT.getSizeInBits() > MaskedVT.getSizeInBits()) && + TLI.isLoadExtLegal(ExtType, N0.getValueType(), MaskedVT)) ExtVT = MaskedVT; } } |
