summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/MachineVerifier.cpp
diff options
context:
space:
mode:
authorJonas Paulsson <jonas.paulsson@ericsson.com>2015-10-21 07:39:47 +0000
committerJonas Paulsson <jonas.paulsson@ericsson.com>2015-10-21 07:39:47 +0000
commit17ad04535faaf580f10c23d6622a55a3aefe845b (patch)
tree0b893eb3f18b2887608373d000447ac4800c81d1 /llvm/lib/CodeGen/MachineVerifier.cpp
parent896c66ecc64e9f8fa80b08b8d9d7eecfce5c3acd (diff)
downloadbcm5719-llvm-17ad04535faaf580f10c23d6622a55a3aefe845b.tar.gz
bcm5719-llvm-17ad04535faaf580f10c23d6622a55a3aefe845b.zip
Let MachineVerifier be aware of mem-to-mem instructions.
A mem-to-mem instruction (that both loads and stores), which store to an FI, cannot pass the verifier since it thinks it is loading from the FI. For the mem-to-mem instruction, do a looser check in visitMachineOperand() and only check liveness at the reg-slot while analyzing a frame index operand. Needed to make CodeGen/SystemZ/xor-01.ll pass with -verify-machineinstrs, which now runs with this flag. Reviewed by Evan Cheng and Quentin Colombet. llvm-svn: 250885
Diffstat (limited to 'llvm/lib/CodeGen/MachineVerifier.cpp')
-rw-r--r--llvm/lib/CodeGen/MachineVerifier.cpp10
1 files changed, 8 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/MachineVerifier.cpp b/llvm/lib/CodeGen/MachineVerifier.cpp
index c21b875a082..b9ca0c51d76 100644
--- a/llvm/lib/CodeGen/MachineVerifier.cpp
+++ b/llvm/lib/CodeGen/MachineVerifier.cpp
@@ -994,11 +994,17 @@ MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
LiveInts && !LiveInts->isNotInMIMap(MI)) {
LiveInterval &LI = LiveStks->getInterval(MO->getIndex());
SlotIndex Idx = LiveInts->getInstructionIndex(MI);
- if (MI->mayLoad() && !LI.liveAt(Idx.getRegSlot(true))) {
+
+ // For a memory-to-memory move, we don't know if MI is using
+ // this frame index for loading or storing, so check for
+ // liveness at reg-slot only in the simple load case.
+ bool stores = MI->mayStore();
+ bool simpleLoad = (MI->mayLoad() && !stores);
+ if (simpleLoad && !LI.liveAt(Idx.getRegSlot(true))) {
report("Instruction loads from dead spill slot", MO, MONum);
errs() << "Live stack: " << LI << '\n';
}
- if (MI->mayStore() && !LI.liveAt(Idx.getRegSlot())) {
+ if (stores && !LI.liveAt(Idx.getRegSlot())) {
report("Instruction stores to dead spill slot", MO, MONum);
errs() << "Live stack: " << LI << '\n';
}
OpenPOWER on IntegriCloud