diff options
author | Matthias Braun <matze@braunis.de> | 2017-01-28 02:02:38 +0000 |
---|---|---|
committer | Matthias Braun <matze@braunis.de> | 2017-01-28 02:02:38 +0000 |
commit | 8c209aa8779de57771b64896f805e14cc0016dcd (patch) | |
tree | b3f7bc33dbb7be8ffe9a4f974253d6547b94ebdb /llvm/lib/CodeGen/MachineInstr.cpp | |
parent | cfa5dc4a1dc2b7495aba96caba6fd2600c1ceb8a (diff) | |
download | bcm5719-llvm-8c209aa8779de57771b64896f805e14cc0016dcd.tar.gz bcm5719-llvm-8c209aa8779de57771b64896f805e14cc0016dcd.zip |
Cleanup dump() functions.
We had various variants of defining dump() functions in LLVM. Normalize
them (this should just consistently implement the things discussed in
http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html
For reference:
- Public headers should just declare the dump() method but not use
LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
- The definition of a dump method should look like this:
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void MyClass::dump() {
// print stuff to dbgs()...
}
#endif
llvm-svn: 293359
Diffstat (limited to 'llvm/lib/CodeGen/MachineInstr.cpp')
-rw-r--r-- | llvm/lib/CodeGen/MachineInstr.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/MachineInstr.cpp b/llvm/lib/CodeGen/MachineInstr.cpp index 2f2e3b3d8e9..b7f8e1ce68b 100644 --- a/llvm/lib/CodeGen/MachineInstr.cpp +++ b/llvm/lib/CodeGen/MachineInstr.cpp @@ -1692,12 +1692,12 @@ void MachineInstr::copyImplicitOps(MachineFunction &MF, } } -LLVM_DUMP_METHOD void MachineInstr::dump(const TargetInstrInfo *TII) const { #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) +LLVM_DUMP_METHOD void MachineInstr::dump(const TargetInstrInfo *TII) const { dbgs() << " "; print(dbgs(), false /* SkipOpers */, TII); -#endif } +#endif void MachineInstr::print(raw_ostream &OS, bool SkipOpers, const TargetInstrInfo *TII) const { |