summaryrefslogtreecommitdiffstats
path: root/clang/tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2013-09-04 16:09:01 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2013-09-04 16:09:01 +0000
commit128c5ea902b54aee7cdc744eff3cd59feb83aedd (patch)
treeced482fe5a3ebbdb5c5c3b9336f98abe5e987776 /clang/tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
parent7d2abdf017b1d4573075ba75419f6fc62c415e3d (diff)
downloadbcm5719-llvm-128c5ea902b54aee7cdc744eff3cd59feb83aedd.tar.gz
bcm5719-llvm-128c5ea902b54aee7cdc744eff3cd59feb83aedd.zip
Revert "Add r159136 back now that pr13124 has been fixed."
This reverts commit r189886. I found a corner case where this optimization is not valid: Say we have a "linkonce_odr unnamed_addr" in two translation units: * In TU 1 this optimization kicks in and makes it hidden. * In TU 2 it gets const merged with a constant that is *not* unnamed_addr, resulting in a non unnamed_addr constant with default visibility. * The static linker rules for combining visibility them produce a hidden symbol, which is incorrect from the point of view of the non unnamed_addr constant. The one place we can do this is when we know that the symbol is not used from another TU in the same shared object, i.e., during LTO. I will move it there. llvm-svn: 189954
Diffstat (limited to 'clang/tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud