summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--llvm/include/llvm/IR/GlobalValue.h6
-rw-r--r--llvm/lib/Transforms/IPO/GlobalOpt.cpp11
-rw-r--r--llvm/test/Transforms/GlobalOpt/hidden.ll14
3 files changed, 0 insertions, 31 deletions
diff --git a/llvm/include/llvm/IR/GlobalValue.h b/llvm/include/llvm/IR/GlobalValue.h
index a5049e4324c..1dc99cfaa41 100644
--- a/llvm/include/llvm/IR/GlobalValue.h
+++ b/llvm/include/llvm/IR/GlobalValue.h
@@ -122,9 +122,6 @@ public:
static bool isAvailableExternallyLinkage(LinkageTypes Linkage) {
return Linkage == AvailableExternallyLinkage;
}
- static bool isLinkOnceODRLinkage(LinkageTypes Linkage) {
- return Linkage == LinkOnceODRLinkage;
- }
static bool isLinkOnceLinkage(LinkageTypes Linkage) {
return Linkage == LinkOnceAnyLinkage ||
Linkage == LinkOnceODRLinkage ||
@@ -205,9 +202,6 @@ public:
bool hasAvailableExternallyLinkage() const {
return isAvailableExternallyLinkage(Linkage);
}
- bool hasLinkOnceODRLinkage() const {
- return isLinkOnceODRLinkage(Linkage);
- }
bool hasLinkOnceLinkage() const {
return isLinkOnceLinkage(Linkage);
}
diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
index ab9d30da473..64cd515f673 100644
--- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp
+++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -1914,12 +1914,6 @@ bool GlobalOpt::ProcessGlobal(GlobalVariable *GV,
return true;
}
- if (GV->hasLinkOnceODRLinkage() && GV->hasUnnamedAddr() && GV->isConstant() &&
- GV->getVisibility() != GlobalValue::HiddenVisibility) {
- GV->setVisibility(GlobalValue::HiddenVisibility);
- return true;
- }
-
if (!GV->hasLocalLinkage())
return false;
@@ -1932,7 +1926,6 @@ bool GlobalOpt::ProcessGlobal(GlobalVariable *GV,
if (!GS.isCompared && !GV->hasUnnamedAddr()) {
GV->setUnnamedAddr(true);
NumUnnamed++;
- return true;
}
if (GV->isConstant() || !GV->hasInitializer())
@@ -2112,10 +2105,6 @@ bool GlobalOpt::OptimizeFunctions(Module &M) {
F->eraseFromParent();
Changed = true;
++NumFnDeleted;
- } else if (F->hasLinkOnceODRLinkage() && F->hasUnnamedAddr() &&
- F->getVisibility() != GlobalValue::HiddenVisibility) {
- F->setVisibility(GlobalValue::HiddenVisibility);
- Changed = true;
} else if (F->hasLocalLinkage()) {
if (F->getCallingConv() == CallingConv::C && !F->isVarArg() &&
!F->hasAddressTaken()) {
diff --git a/llvm/test/Transforms/GlobalOpt/hidden.ll b/llvm/test/Transforms/GlobalOpt/hidden.ll
deleted file mode 100644
index 301e158d534..00000000000
--- a/llvm/test/Transforms/GlobalOpt/hidden.ll
+++ /dev/null
@@ -1,14 +0,0 @@
-; RUN: opt %s -globalopt -S | FileCheck %s
-
-@foo = linkonce_odr unnamed_addr constant i32 42
-; CHECK: @foo = linkonce_odr hidden unnamed_addr constant i32 42
-
-define linkonce_odr void @bar() unnamed_addr {
-; CHECK: define linkonce_odr hidden void @bar() unnamed_addr {
- ret void
-}
-
-define i32* @zed() {
- call void @bar()
- ret i32* @foo
-}
OpenPOWER on IntegriCloud