diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2015-02-17 16:48:30 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2015-02-17 16:48:30 +0000 |
| commit | f989042f181cbf4d55e74f3ff1a75bc1b765a2a6 (patch) | |
| tree | 3a5a3e33192efd1c94685473edf3b02263c32d00 /clang/lib/Driver/Job.cpp | |
| parent | bc3776803b817e2384e1665cede66133d661c593 (diff) | |
| download | bcm5719-llvm-f989042f181cbf4d55e74f3ff1a75bc1b765a2a6.tar.gz bcm5719-llvm-f989042f181cbf4d55e74f3ff1a75bc1b765a2a6.zip | |
Prefer SmallVector::append/insert over push_back loops. Clang edition.
Same functionality, but hoists the vector growth out of the loop.
llvm-svn: 229508
Diffstat (limited to 'clang/lib/Driver/Job.cpp')
| -rw-r--r-- | clang/lib/Driver/Job.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp index c5b3f5a307b..66434cf7b01 100644 --- a/clang/lib/Driver/Job.cpp +++ b/clang/lib/Driver/Job.cpp @@ -217,8 +217,7 @@ int Command::Execute(const StringRef **Redirects, std::string *ErrMsg, if (ResponseFile == nullptr) { Argv.push_back(Executable); - for (size_t i = 0, e = Arguments.size(); i != e; ++i) - Argv.push_back(Arguments[i]); + Argv.append(Arguments.begin(), Arguments.end()); Argv.push_back(nullptr); return llvm::sys::ExecuteAndWait(Executable, Argv.data(), /*env*/ nullptr, |
