From f989042f181cbf4d55e74f3ff1a75bc1b765a2a6 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Tue, 17 Feb 2015 16:48:30 +0000 Subject: Prefer SmallVector::append/insert over push_back loops. Clang edition. Same functionality, but hoists the vector growth out of the loop. llvm-svn: 229508 --- clang/lib/Driver/Job.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'clang/lib/Driver/Job.cpp') diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp index c5b3f5a307b..66434cf7b01 100644 --- a/clang/lib/Driver/Job.cpp +++ b/clang/lib/Driver/Job.cpp @@ -217,8 +217,7 @@ int Command::Execute(const StringRef **Redirects, std::string *ErrMsg, if (ResponseFile == nullptr) { Argv.push_back(Executable); - for (size_t i = 0, e = Arguments.size(); i != e; ++i) - Argv.push_back(Arguments[i]); + Argv.append(Arguments.begin(), Arguments.end()); Argv.push_back(nullptr); return llvm::sys::ExecuteAndWait(Executable, Argv.data(), /*env*/ nullptr, -- cgit v1.2.3