diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2018-02-23 18:09:29 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2018-02-23 18:09:29 +0000 |
commit | 43ce3a3a4d83071eb3acfe21cba4f051d267674a (patch) | |
tree | 0613838e3de14d5422edbdb0bedc2e52bbf1030c /clang/lib/CodeGen/CodeGenModule.cpp | |
parent | 967cb19146d24464d2a3691761f893e72253eb8e (diff) | |
download | bcm5719-llvm-43ce3a3a4d83071eb3acfe21cba4f051d267674a.tar.gz bcm5719-llvm-43ce3a3a4d83071eb3acfe21cba4f051d267674a.zip |
Revert "Start setting dso_local for COFF."
This reverts commit r325915.
It will take some time to fix the failures on a windows host.
llvm-svn: 325929
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 03bf2169157..e8577b0153f 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -713,20 +713,8 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV, static bool shouldAssumeDSOLocal(const CodeGenModule &CGM, llvm::GlobalValue *GV) { - // DLLImport explicitly marks the GV as external. - if (GV->hasDLLImportStorageClass()) - return false; - const llvm::Triple &TT = CGM.getTriple(); - // Every other GV is local on COFF. - // Make an exception for windows OS in the triple: Some firmware builds use - // *-win32-macho triples. This (accidentally?) produced windows relocations - // without GOT tables in older clang versions; Keep this behaviour. - // FIXME: even thread local variables? - if (TT.isOSBinFormatCOFF() || (TT.isOSWindows() && TT.isOSBinFormatMachO())) - return true; - - // Only handle COFF and ELF for now. + // Only handle ELF for now. if (!TT.isOSBinFormatELF()) return false; |