From 43ce3a3a4d83071eb3acfe21cba4f051d267674a Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Fri, 23 Feb 2018 18:09:29 +0000 Subject: Revert "Start setting dso_local for COFF." This reverts commit r325915. It will take some time to fix the failures on a windows host. llvm-svn: 325929 --- clang/lib/CodeGen/CodeGenModule.cpp | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) (limited to 'clang/lib/CodeGen/CodeGenModule.cpp') diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 03bf2169157..e8577b0153f 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -713,20 +713,8 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV, static bool shouldAssumeDSOLocal(const CodeGenModule &CGM, llvm::GlobalValue *GV) { - // DLLImport explicitly marks the GV as external. - if (GV->hasDLLImportStorageClass()) - return false; - const llvm::Triple &TT = CGM.getTriple(); - // Every other GV is local on COFF. - // Make an exception for windows OS in the triple: Some firmware builds use - // *-win32-macho triples. This (accidentally?) produced windows relocations - // without GOT tables in older clang versions; Keep this behaviour. - // FIXME: even thread local variables? - if (TT.isOSBinFormatCOFF() || (TT.isOSWindows() && TT.isOSBinFormatMachO())) - return true; - - // Only handle COFF and ELF for now. + // Only handle ELF for now. if (!TT.isOSBinFormatELF()) return false; -- cgit v1.2.3