diff options
author | Sam McCall <sam.mccall@gmail.com> | 2018-11-02 13:06:55 +0000 |
---|---|---|
committer | Sam McCall <sam.mccall@gmail.com> | 2018-11-02 13:06:55 +0000 |
commit | 2eb6b4038a2a66a413efce8892d4c82ca6762e13 (patch) | |
tree | d54502db574743604a67a857b474b7ec21dde2ac /clang-tools-extra/clangd/Protocol.h | |
parent | 3fd25fcf36aaf7945f1669bce4f5aa5c9bf36bb6 (diff) | |
download | bcm5719-llvm-2eb6b4038a2a66a413efce8892d4c82ca6762e13.tar.gz bcm5719-llvm-2eb6b4038a2a66a413efce8892d4c82ca6762e13.zip |
[clangd] Remove didOpen extraFlags extension.
Summary:
This was added in D34947 to support YCM, but YCM actually provides *all* args,
and this was never actually used.
Meanwhile, we grew another extension that allows specifying all args.
I did find one user of this extension: https://github.com/thomasjo/atom-ide-cpp.
I'll reach out, there are multiple good alternatives:
- compile_commands.txt can serve the same purpose as .clang_complete there
- we can add an extension to support setting the fallback command
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differential Revision: https://reviews.llvm.org/D53641
llvm-svn: 345969
Diffstat (limited to 'clang-tools-extra/clangd/Protocol.h')
-rw-r--r-- | clang-tools-extra/clangd/Protocol.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/clang-tools-extra/clangd/Protocol.h b/clang-tools-extra/clangd/Protocol.h index 30352494c71..bfa7757b1b1 100644 --- a/clang-tools-extra/clangd/Protocol.h +++ b/clang-tools-extra/clangd/Protocol.h @@ -175,11 +175,6 @@ struct Location { llvm::json::Value toJSON(const Location &); llvm::raw_ostream &operator<<(llvm::raw_ostream &, const Location &); -struct Metadata { - std::vector<std::string> extraFlags; -}; -bool fromJSON(const llvm::json::Value &, Metadata &); - struct TextEdit { /// The range of the text document to be manipulated. To insert /// text into a document create a range where start === end. @@ -411,9 +406,6 @@ bool fromJSON(const llvm::json::Value &, InitializeParams &); struct DidOpenTextDocumentParams { /// The document that was opened. TextDocumentItem textDocument; - - /// Extension storing per-file metadata, such as compilation flags. - llvm::Optional<Metadata> metadata; }; bool fromJSON(const llvm::json::Value &, DidOpenTextDocumentParams &); |