From 2eb6b4038a2a66a413efce8892d4c82ca6762e13 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Fri, 2 Nov 2018 13:06:55 +0000 Subject: [clangd] Remove didOpen extraFlags extension. Summary: This was added in D34947 to support YCM, but YCM actually provides *all* args, and this was never actually used. Meanwhile, we grew another extension that allows specifying all args. I did find one user of this extension: https://github.com/thomasjo/atom-ide-cpp. I'll reach out, there are multiple good alternatives: - compile_commands.txt can serve the same purpose as .clang_complete there - we can add an extension to support setting the fallback command Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revision: https://reviews.llvm.org/D53641 llvm-svn: 345969 --- clang-tools-extra/clangd/Protocol.h | 8 -------- 1 file changed, 8 deletions(-) (limited to 'clang-tools-extra/clangd/Protocol.h') diff --git a/clang-tools-extra/clangd/Protocol.h b/clang-tools-extra/clangd/Protocol.h index 30352494c71..bfa7757b1b1 100644 --- a/clang-tools-extra/clangd/Protocol.h +++ b/clang-tools-extra/clangd/Protocol.h @@ -175,11 +175,6 @@ struct Location { llvm::json::Value toJSON(const Location &); llvm::raw_ostream &operator<<(llvm::raw_ostream &, const Location &); -struct Metadata { - std::vector extraFlags; -}; -bool fromJSON(const llvm::json::Value &, Metadata &); - struct TextEdit { /// The range of the text document to be manipulated. To insert /// text into a document create a range where start === end. @@ -411,9 +406,6 @@ bool fromJSON(const llvm::json::Value &, InitializeParams &); struct DidOpenTextDocumentParams { /// The document that was opened. TextDocumentItem textDocument; - - /// Extension storing per-file metadata, such as compilation flags. - llvm::Optional metadata; }; bool fromJSON(const llvm::json::Value &, DidOpenTextDocumentParams &); -- cgit v1.2.3