summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
diff options
context:
space:
mode:
authorJonathan Coe <jbcoe@me.com>2016-11-03 13:52:09 +0000
committerJonathan Coe <jbcoe@me.com>2016-11-03 13:52:09 +0000
commit89f12c0c50dc6254b9df5a09e7cc116eddc4af86 (patch)
tree2ca1e564a0bc1afe18d4f4588ea2b6ce76bc4eb1 /clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
parentdd6abaad7562d6dc1a8f735e2647c35fcf74baa2 (diff)
downloadbcm5719-llvm-89f12c0c50dc6254b9df5a09e7cc116eddc4af86.tar.gz
bcm5719-llvm-89f12c0c50dc6254b9df5a09e7cc116eddc4af86.zip
[clang-tidy] Ignore forward declarations without definitions in the same translation unit in readability-identifier-naming
Summary: This change ensures that forward declarations of classes are not considered for identifier naming checks within a translation unit. Reviewers: alexfh, aaron.ballman Subscribers: mgehre Differential Revision: https://reviews.llvm.org/D22571 llvm-svn: 285907
Diffstat (limited to 'clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
index bca5d465f60..f3b29302ee5 100644
--- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
@@ -395,6 +395,9 @@ static StyleKind findStyleKind(
if (Decl->isAnonymousStructOrUnion())
return SK_Invalid;
+ if (!Decl->getCanonicalDecl()->isThisDeclarationADefinition())
+ return SK_Invalid;
+
if (Decl->hasDefinition() && Decl->isAbstract() &&
NamingStyles[SK_AbstractClass].isSet())
return SK_AbstractClass;
OpenPOWER on IntegriCloud