From 89f12c0c50dc6254b9df5a09e7cc116eddc4af86 Mon Sep 17 00:00:00 2001 From: Jonathan Coe Date: Thu, 3 Nov 2016 13:52:09 +0000 Subject: [clang-tidy] Ignore forward declarations without definitions in the same translation unit in readability-identifier-naming Summary: This change ensures that forward declarations of classes are not considered for identifier naming checks within a translation unit. Reviewers: alexfh, aaron.ballman Subscribers: mgehre Differential Revision: https://reviews.llvm.org/D22571 llvm-svn: 285907 --- clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp') diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp index bca5d465f60..f3b29302ee5 100644 --- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp @@ -395,6 +395,9 @@ static StyleKind findStyleKind( if (Decl->isAnonymousStructOrUnion()) return SK_Invalid; + if (!Decl->getCanonicalDecl()->isThisDeclarationADefinition()) + return SK_Invalid; + if (Decl->hasDefinition() && Decl->isAbstract() && NamingStyles[SK_AbstractClass].isSet()) return SK_AbstractClass; -- cgit v1.2.3