diff options
author | Chih-Hung Hsieh <chh@google.com> | 2017-08-14 17:04:16 +0000 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2017-08-14 17:04:16 +0000 |
commit | 56650e7fc58770fbfecfad746222da47cb208f5e (patch) | |
tree | 1f1e316c2060697275b4cd1a14d0a5237b848c5e /clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | |
parent | 533d4c90bda5aa40a81671bbf8b059e91fb24925 (diff) | |
download | bcm5719-llvm-56650e7fc58770fbfecfad746222da47cb208f5e.tar.gz bcm5719-llvm-56650e7fc58770fbfecfad746222da47cb208f5e.zip |
[clang-tidy] Add a close-on-exec check on dup() in Android module.
Summary:
dup() is better to be replaced by fcntl() to avoid file descriptor leakage.
Differential Revision: https://reviews.llvm.org/D35364
llvm-svn: 310858
Diffstat (limited to 'clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp index 729047ee35e..71c6accba97 100644 --- a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp @@ -11,6 +11,7 @@ #include "../ClangTidyModule.h" #include "../ClangTidyModuleRegistry.h" #include "CloexecCreatCheck.h" +#include "CloexecDupCheck.h" #include "CloexecFopenCheck.h" #include "CloexecMemfdCreateCheck.h" #include "CloexecOpenCheck.h" @@ -27,6 +28,7 @@ class AndroidModule : public ClangTidyModule { public: void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { CheckFactories.registerCheck<CloexecCreatCheck>("android-cloexec-creat"); + CheckFactories.registerCheck<CloexecDupCheck>("android-cloexec-dup"); CheckFactories.registerCheck<CloexecFopenCheck>("android-cloexec-fopen"); CheckFactories.registerCheck<CloexecMemfdCreateCheck>( "android-cloexec-memfd-create"); |