From 56650e7fc58770fbfecfad746222da47cb208f5e Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 14 Aug 2017 17:04:16 +0000 Subject: [clang-tidy] Add a close-on-exec check on dup() in Android module. Summary: dup() is better to be replaced by fcntl() to avoid file descriptor leakage. Differential Revision: https://reviews.llvm.org/D35364 llvm-svn: 310858 --- clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp') diff --git a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp index 729047ee35e..71c6accba97 100644 --- a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp @@ -11,6 +11,7 @@ #include "../ClangTidyModule.h" #include "../ClangTidyModuleRegistry.h" #include "CloexecCreatCheck.h" +#include "CloexecDupCheck.h" #include "CloexecFopenCheck.h" #include "CloexecMemfdCreateCheck.h" #include "CloexecOpenCheck.h" @@ -27,6 +28,7 @@ class AndroidModule : public ClangTidyModule { public: void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { CheckFactories.registerCheck("android-cloexec-creat"); + CheckFactories.registerCheck("android-cloexec-dup"); CheckFactories.registerCheck("android-cloexec-fopen"); CheckFactories.registerCheck( "android-cloexec-memfd-create"); -- cgit v1.2.3