summaryrefslogtreecommitdiffstats
path: root/hw/fsp
Commit message (Collapse)AuthorAgeFilesLines
...
* | FSP/LED: Validate before creating led nodeVasant Hegde2015-05-071-3/+4
| | | | | | | | | | | | | | | | | | | | | | We get SAI indicator via HDAT. So we have to create led node while parsing HDAT itself. Lets get led node from device tree. Note that LED DT creation fails until next commit...which creates LED device tree node. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LED: Define macro instead of hardcoding led typeVasant Hegde2015-05-071-5/+8
| | | | | | | | | | | | | | | | Define macors for LED related device tree property and its values. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LED: Move led header file to include directoryVasant Hegde2015-05-072-155/+1
| | | | | | | | | | | | | | | | | | | | We want to refer leds header file in hdata. Hence move header file to include directory. No functionality changes. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | surv: Fix "hearbeat" typoAnton Blanchard2015-04-291-3/+3
| | | | | | | | | | | | | | | | | | | | | | I get thousands of these in my OPAL message log so they may as well be spelled correctly. While here, make the other messages consistent by changing hbeat to heartbeat. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/CUPD: Remove CamelCaseVasant Hegde2015-04-152-27/+27
| | | | | | | | | | | | | | No functionality changes. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/CUPD: Fix lock issueVasant Hegde2015-04-091-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Commit a5ee9d40 does unlock/lock of flash_lock in fsp_code_update_wait_vpd(). This function is called during init as well (where we enter this function without lock). And in corner cases (CUPD init is not completed) when we entered this function (in init path) then we hit lock error. Also remove redundant lock from fsp_flash_firmware...which solves possible poller lock issue. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | Remove redundant includes of opal-api.hMichael Ellerman2015-04-019-9/+0
| | | | | | | | | | | | | | | | Now that opal.h includes opal-api.h, there are a bunch of files that include both but don't need to. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | opal: Fix an issue where partial LID load causes opal to hang.Mahesh Salgaonkar2015-03-311-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit c789772 introduced an asynchronous mechanism to load LID resource for FSP systems. But after this change some of the FSP based system failed to load/boot petitboot kernel. While fetching LID resource in multiple chunks, we depend on return status from FSP whether there is more data available to fetch or not. As per FSP mailbox documentation, fetch cmd returns status=2 which means, there is more data pending, and status=0 means we have reached end-of-file. But in reality FSP don't behave as per the document. It looks like we always get status=0 irrespective of whether end of file is reached or not. The old implementation (fsp_sync_msg) used to rely on (wlen < chunk) check to decide whether we reached end of file or not. Ideally, FSP folks should be fix their code as per documentation. But until they do, adding the old check back here again. Without this patch some system won't be able to boot into petitboot kernel. Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LED: Validate before creating LED nodesVasant Hegde2015-03-261-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | If FSP messes up SLCA data then attention location code points to some other location code and its possible that we may endup in duplicate LED location code :-( Better to continue with partial LED list than crashing OPAL because of duplicate node in device tree. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> [stewart@linux.vnet.ibm.com: prlog(PR_WARNING) on duplicate found] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LED: Continue processing LED update request in error pathVasant Hegde2015-03-261-4/+6
| | | | | | | | | | | | | | | | | | | | | | Presently if fsp_msg_set_led_state() fails then we don't continue processing remaining LED update request...which is not correct. Also free spcn_cmd in one place rather than freeing at every failure block. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp-sensor: add a label property for the ambient sensorCédric Le Goater2015-03-241-0/+4
| | | | | | | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | core: add a platform op to read sensorsCédric Le Goater2015-03-241-9/+4
| | | | | | | | | | | | | | | | | | | | This patch introduces an initial framework to define a sensor_read operation per platform. It also proposes a few helper routines to work on the sensor 'handler' which identifies a sensor and attribute in the OPAL_SENSOR_READ call. Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | Asynchronous LID/Resource loading for FSP systemsStewart Smith2015-03-241-104/+274
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves away from using fsp_sync_msg in fsp_fetch_data and instead using the platform hooks for start_preload_resource() to actually queue up a load and having the plumbing for checking if a resource is loaded yet. This gets rid of the "pollers called with locks held" warning we got heaps of previously. You can now boot some FSP systems without getting this warning at all. This also sets the stage for starting load of LIDs much earlier to when they're needed, improving boot time. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | Change load_resource() API to be all about preloading.Stewart Smith2015-03-231-7/+7
| | | | | | | | | | | | | | | | | | No functional changes in what happens, just have two calls, one for queueing preload the other for waiting until it has loaded. future patches will introduce platform specific queueing. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/SYSPARAM: Fix memory leak in error pathVasant Hegde2015-03-211-3/+8
| | | | | | | | | | Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Roll back exclusive bit in case FSP command queuing failsVasant Hegde2015-03-202-18/+23
| | | | | | | | | | | | | | | | | | | | | | Presently we update enclosure exclusive bit before making LED update SPCN passthrough command and not reverting if this command fails. So we endup having wrong state if SPCN passthrough command fails. This patch fixes above described issue. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Add OPAL interfaces for accessing or modifying the LED statesVasant Hegde2015-03-202-6/+225
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds and registers the following two new OPAL interfaces for the LED subsystem. With the help of these new OPAL calls, the host will be able to set or query the state of various LEDs on the system at any given location code (as passed in the device tree). As of now, it supports two kinds of LEDs on the same location code one is "Identify LED" and the other being the "Fault LED". (1) OPAL_LEDS_GET_INDICATOR fsp_opal_leds_get_ind (2) OPAL_LEDS_SET_INDICATOR fsp_opal_leds_set_ind The signtaure of these OPAL interfaces are like the following (1) fsp_opal_leds_get_ind(loc_code, led_mask, led_value, led_max_type) The host will pass the location code of the LED (loc_code) and maximum number of LED types it understands (led_max_type). Sapphire updates the led_mask with set bits pointing to LED types whose status is availbale and updates the led_value with actual status. Sapphire checks the led_max_type to understand whether host is newer or older compared to itself. In the case where the Sapphire is newer compared to host (Sapphire's led_max_type > host's led_max_type), it will update led_mask and led_value according to led_max_type requested by the host. When the host is newer compared to the Sapphire (host's led_max_type > Sapphire's led_max_type), Sapphire updates led_max_type to the maximum number of LED type it understands and updates led_mask, led_value based on that maximum value. (2) fsp_opal_leds_set_ind(loc_code, led_mask, led_value, led_max_type) The host will pass the location code of the LED types, mask, value and maximum number of LED types it understands. Sapphire will update LED status for all the LED types mentioned in the mask with their value mentioned. Sapphire checks the 'led_max_type' to understand whether the host is newer or older compared to itself. In case where the Sapphire is newer compared to the host (Sapphire's led_max_type > host's led_max_type), it updates LED status based on led_max_type requested from the host. When the host is newer compared to the Sapphire (host's led_max_type > Sapphire's led_max_type), Sapphire updates 'led_max_type' to the maximum number of LED type it understands and then it updates LED status based on that updated maximum value of LED types. Host needs to check the returned updated value of led_max_type to figure out which part of it's request got served and which ones got ignored. Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Handle failure cases in set LED MBOX commandVasant Hegde2015-03-201-69/+58
| | | | | | | | | | | | | | | | | | | | | | If set LED mbox command fails then we have to respond to FSP with apropriate status code. Moved MBOX response code to separate function so that we can just call that with different status code. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Roll back LED state update in case FSP command queuing failsAnshuman Khandual2015-03-201-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The LED local state gets updated before queuing the FSP command. If the command returns in error state, the state gets rolled back in the function callback. But in case where the FSP command queue it self fails, it does not get rolled back. This patch fixes this scenario by rolling back the state change in case the FSP command queuing itself fails. Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Serialize the entire LED state change code and it's callbackAnshuman Khandual2015-03-201-2/+10
| | | | | | | | | | | | | | | | | | | | This patch increase the scope of the lock to cover all data structure manipulation and SPCN command queuing to change the LED state. It also locks the corresponding sections in the function callback. Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Modify handling of SPCN based LED commandsAnshuman Khandual2015-03-202-10/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OPAL queues up asynchronous SPCN command to change the state of any given LED with a function call back. After receiving the call back, it sends acknowledgement message to the FSP for the previous command. But in case of OPAL interface initiated LED state changes, no ack message needs to be sent to the FSP, instead we might want to enable some flags for OPAL indicating the success of the previous LED request thus making the OPAL interface ready for subsequent commands from the host. This creates a need to distinguish between SPCN based LED commands generated because of FSP async interface compared to that of OPAL interface. This patch achieves the classification and other needfull changes in this regard. These changes will be necessary and used by OPAL interface in subsequent patches in this series. Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Move checkpoint status variable to led_set_cmd structureVasant Hegde2015-03-202-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | "fsp_led_data" structure contains ckpt_status variable which keeps current LED state before updating and if LED update fails then we use this to revert the LED state. We have introduced new structure (led_set_cmd) to queue up LED update requests. It make sense to move checkpoint status variable to this new structure. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Add device tree nodesVasant Hegde2015-03-201-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch creates a parent LED device node called 'led' under the root 'opal' device node. This also creates child device nodes under 'led' corresponding to all individual LEDs on the system whether it is an enclosure type or a descendant type with their location code as name. The location code information will be used by the host to enlist and access all the individual LEDs present on the system. The child LED device nodes also have the properties 'led-types' and 'led-loc' representing what kind of LEDs present on the same loation code and whether it is an enclosure type LED or a descendant type LED. Sample device tree output: ibm,opal { .. .. led { compatible = "ibm,opal-v3-led"; phandle = <0x1000006b>; linux,phandle = <0x1000006b>; U78C9.001.RST0027-P1-C1 { led-types = "identify", "fault"; led-loc = "descendent"; phandle = <0x1000006f>; linux,phandle = <0x1000006f>; }; <snip> }; }; Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> [stewart@linux.vnet.ibm.com: Move create_led_device_nodes to FSP platform.exit] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp: Fix FSP irq initialization on PSIHBCR for resetsAnanth N Mavinakayanahalli2015-03-171-1/+3
| | | | | | | | | | | | | | | | During Reset/Reload, we currently enable FSP interrupts on PSIHBCR even before the DISR handshake is complete. Fix that. Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/RTC: Check for TOD state in fsp_opal_rtc_readVasant Hegde2015-03-101-11/+19
| | | | | | | | | | | | | | | | Check for TOD state before returning cached time in fsp_opal_rtc_read. Also improve error handling. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp/rtc: Introduce the rtc write state machineNeelesh Gupta2015-03-101-44/+74
| | | | | | | | | | | | | | | | | | Similar to rtc read requests, have a state machine to handle the write transitions. Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com> Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp/rtc: Rename the rtc_request_state to rtc_read_request_stateNeelesh Gupta2015-03-101-19/+20
| | | | | | | | | | | | | | | | | | The rtc_request_state handles the state transition for rtc read requests only, so rtc_read_request_state is more appropriate name. Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com> Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | Refactor fsp-rtc.c to not call fsp_sync_msg (and thus pollers) with lock heldStewart Smith2015-03-061-83/+71
| | | | | | | | | | | | | | | | | | | | We introduce simple state machine, have liberal assert()s and very clearly indicate what's protected by the lock (everything). We also stop waiting for the initial RTC response on boot, which will ever so slightly speed up booting. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | sparse: rtc_tod_state and rtc_tod_cache_dirty and be staticCédric Le Goater2015-03-051-2/+2
| | | | | | | | | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | sparse: fsp_dpo_init_tb can be staticCédric Le Goater2015-02-261-1/+1
| | | | | | | | | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | sparse: epow_status can be staticCédric Le Goater2015-02-261-1/+1
| | | | | | | | | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | sparse: elog_write_to_host_head_state can be staticCédric Le Goater2015-02-261-1/+1
| | | | | | | | | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | sparse: led_support can be staticCédric Le Goater2015-02-261-1/+1
| | | | | | | | | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | sparse: fix fsp_fillmsg definitionCédric Le Goater2015-02-261-1/+1
| | | | | | | | | | | | | | | | hw/fsp/fsp.c:920:13: warning: function 'fsp_fillmsg' with external linkage has definition Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | capi: Add CAPI microcode read to load_resource()Michael Neuling2015-02-231-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Add ability to read CAPI microcode to load_resource() implementations. We use the cfam chipid as the subid. FSP load_resource() contains a map of cfam chipid to lid numbers. PNOR load_resource() doesn't change, but requires a properly formatted partition with EC values in the TOC matching the appropriate cfam chipid. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp-op-panel: don't call fsp_sync_msg with lock heldStewart Smith2015-02-181-33/+45
| | | | | | | | | | | | | | Use allocated fsp message in usual case, fall back to static one in the event of a fatal error. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp/console: Don't time_wait with lock heldBenjamin Herrenschmidt2015-02-181-2/+2
| | | | | | | | | | Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | fsp: Audit callers of opal_run_pollersBenjamin Herrenschmidt2015-02-182-13/+24
| | | | | | | | | | | | | | Use cpu_relax() and don't call it with a lock held Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Implement a set LED SPCN command queueVasant Hegde2015-02-172-28/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simultaneous FSP async commands and OPAL requests to change various LED states will generate multiple SPCN commands back to back before their callback get processed. With this, some of the SPCN requests might get overridden with the newer ones and hence will be lost. This patch implements a set LED SPCN command queue which will serialize multiple SPCN commands generated either through FSP async or OPAL requests. All new requests are added to the queue when any previous SPCN command completion is still pending. These requests would be de-queued and then processed inside the SPCN command callback function sequentially. This ensures completion of all the generated LED state change requests without any loss. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> [stewart@linux.vnet.ibm.com: s/spcn_cmd_cmplt/spcn_cmd_complete/] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | core: Add subid to load_resource()Michael Neuling2015-02-171-13/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a subid to load_resource() so that sub-partitions can be accessed inside a PNOR partition. These sub-partitions follow the format used by the hostboot SBE image. The subid will match on the EC field of the SBE table of contents. If it's found, only that sub-partition is returned to the caller. Current partitions (kernel and ramfs) don't support sub-partitions. If caller tries to access a sub-partition within these, we fail the call. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Track LED list read statusVasant Hegde2015-02-131-8/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are going to expose LED list to host via device tree. We want to make sure 'query LED list' MBOX command is completed before populating the device tree. fsp_led_init initiates async MBOX command to retrieve list of LEDs. And towards the end of OPAL init path we will come back to LED driver and populate device tree. We can reuse existing led_support variable to check the status before populating device tree. But this doesn't guarantee that LED list read request is completed. Hence modify led_support to have multiple state. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Remove redundant log messageVasant Hegde2015-02-131-2/+0
| | | | | | | | | | | | | | | | | | There may be other drivers which are registered for same MCLASS. Hence don't log warning message in default case.. Just return false. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Check FSP response statusVasant Hegde2015-02-131-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Presently we check only selected status from SPCN passthrough command. So if MBOX command fails for any other reason then we endup considering that as success...which is not correct. This patch considers all response status except success as fail. Also removes unnecessary variable (fail). Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Validate fsp msg allocationVasant Hegde2015-02-131-0/+2
| | | | | | | | | | | | | | Validate fsp msg allocation before using. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Remove redundant variable declarationVasant Hegde2015-02-131-3/+1
| | | | | | | | | | | | | | Remove redundant variable declaration Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Do not expose driver specific functionsVasant Hegde2015-02-131-4/+4
| | | | | | | | | | | | | | Don't expose functions which are not used outside LED driver. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Use consistent prefixVasant Hegde2015-02-131-40/+47
| | | | | | | | | | | | | | | | | | | | Presently errors logged into FSP starts with prefix "LED" and rest starts with FSPLED. Lets use consistent prefix (FSPLED). No change in functionality. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Check for FSP presenceVasant Hegde2015-02-131-0/+3
| | | | | | | | | | | | | | Check for FSP presence before initializing LED driver. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Remove unnecessary forward declarationVasant Hegde2015-02-131-2/+1
| | | | | | | | | | | | | | Remove unnecessary forward declaration. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | FSP/LEDS: Remove unnecessary header filesVasant Hegde2015-02-131-8/+1
| | | | | | | | | | | | | | | | | | Remove enthusiastic use of #includes in FSP/LEDS code. ...like hdata.h which is not expected to be used outside hdata dir. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
OpenPOWER on IntegriCloud