summaryrefslogtreecommitdiffstats
path: root/external
Commit message (Collapse)AuthorAgeFilesLines
...
* external: Create shared rules.mkBrad Bishop2016-06-072-5/+5
| | | | | | | | Building a dynamically linked pflash will need the shared library name. Export it here. Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Remove -m64 from shared CFLAGS on ARMBrad Bishop2016-06-071-1/+4
| | | | | | | -m64 isn't an ARM flag. Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Fix pflash install targetBrad Bishop2016-06-071-0/+1
| | | | | | | The install target used $(sbindir) which isn't set anywhere. Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Remove external/shared link targetsBrad Bishop2016-06-071-12/+0
| | | | | | | | These are already defined just like we need them in common/rules.mk Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* gard: fix compile error on ARMCédric Le Goater2016-06-071-3/+3
| | | | | | | | | | | | | | | | gard can be used on the BMC to query garded records, but currently compile fails with : cc -O2 -Wall -Werror -I. -c gard.c -o gard.o gard.c: In function 'do_clear_i': gard.c:421:12: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' [-Werror=format] gard.c: In function 'check_gard_partition': gard.c:489:36: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format] This patches provides a fix compatible with x86, armel, ppc64. Signed-off-by: Cédric Le Goater <clg@kaod.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: add support for manipulating file rather than flashStewart Smith2016-05-181-2/+9
| | | | | | | | | | Add command line parameters for passing into libflash to have pflash manipulate a file rather than flash. This is useful for testing. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> Reviewed-by: Cyril Bur <cyril.bur@au1.ibm.com>
* external: add a gitignore to xscom-utilsCédric Le Goater2016-05-111-0/+3
| | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Handle incorrect cmd-line options betterCyril Bur2016-05-031-6/+27
| | | | | | | | | | | | | | | | | | The current pflash cmd-line option parsing has two flaws. Firstly, the error reporting leaves quite a bit to be desired. That is, when invalid options or argument are found, not much reporting is done. This patch addresses this. Secondly, pflash doesn't detect when there are leftovers in argv. This often signals a typo in what the user meant to do and could lead to the wrong outcome. For example: `pflash -e -p zImage.next - P BOOTKERNEL` will do quite the wrong thing. This patch addresses both issues. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* gard: disable cross compile for travisStewart Smith2016-05-031-2/+2
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* gard: remove err.h includeStewart Smith2016-05-021-1/+0
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* fix gard help output testStewart Smith2016-05-021-1/+1
| | | | | Fixes: c51ceb9b9a380a7ed8e2af5b4d5e6c33386cd6f9 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Fix gard --help outputStewart Smith2016-04-291-1/+1
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/fwts: Add parser to extract olog pattern definitionsJeremy Kerr2016-04-281-0/+229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fwts project has a facility to scan system logs for interesting error messages, by matching on patterns in a JSON file. Recently, Deb has added support for the OPAL msglog to fwts, called 'olog': http://kernel.ubuntu.com/git/hwe/fwts.git/commit/?id=652b79b However, we don't yet have any patterns for OPAL. Rather than generate a separate set of patterns that may go stale, Anton suggested that we may want to pull these directly from the OPAL source. This change implements a parser to generate olog pattern definitions from annotations in OPAL itself. For example, a check in the flash code might look like: if (!ffs) { /** * @fwts-label SystemFlashNoPartitionTable * @fwts-advice OPAL Could not read a partition table on * system flash. Since we've still booted the machine (which * requires flash), check that we're registering the proper * system flash device. */ prlog(PR_WARNING, "FLASH: attempted to register system flash " "%s, wwhich has no partition info\n", name); return; } By running generate-fwts-olog on the codebase, we get: { "olog_error_warning_patterns": [ { "advice": "OPAL Could not read a partition table on system flash. Since we've still booted the machine (which requires flash), check that we're registering the proper system flash device.", "compare_mode": "regex", "label": "SystemFlashNoPartitionTable", "level": "LOG_LEVEL_HIGH", "pattern": "FLASH: attempted to register system flash .*, wwhich has no partition info" } ] } - which is suitable for input to the fwts pattern definitions. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> [stewart@linux.vnet.ibm.com: squash trailing whitespace] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Remove reliance on env(SIMHOST)Michael Neuling2016-04-281-5/+3
| | | | | | | | | The SIMHOST environment variable is not present in all version of mambo. This removes the reliance on it and instead uses the "display default_configure" command to find the simulator type. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Flatten device tree at the endMichael Neuling2016-04-181-4/+3
| | | | | | | | | Flatten device tree at the end to ensure we've configured everything first. Otherwise we may get an old dump of the device tree in skiboot. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Increase memory to 4GB and change memory mapMichael Neuling2016-04-181-2/+4
| | | | | | | | | | | Increase memory in the sim to 4GB up from 1GB. We need to turn off the small RAM and ROM in mambo as that sits at 3.75GB currently. We don't use these currently. Also change where we put the CPIO to give ourselves more space. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Update gitignore for building opal-prdMichael Neuling2016-04-182-0/+4
| | | | | | | Building opal-prd currently leaves the git tree dirty. This fixes it. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/opal-prd: Ensure that struct host_interfaces matches the thunkJeremy Kerr2016-04-183-1/+28
| | | | | | | | | | | | Currently, we don't describe the reserved area at the end of struct host_interfaces; it's in the thunk, but not the struct itself. This change adds the reserved area, and adds a set of runtime asserts to ensure that the struct layout matches the thunk. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Acked-by: Balbir Singh <bsingharora@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* boot-tests: allow running boot_test.sh via a symlinkAndrew Donnellan2016-04-181-1/+1
| | | | | | | | | In boot_test.sh, use readlink when working out the path to source {fsp,bmc}_support.sh, so the script doesn't fail when run using a symlink from outside the boot-tests directory. Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Enable multicore configurationsMichael Neuling2016-04-171-13/+23
| | | | | | | | | | | | | This enables multicore configurations in mambo. You can change the number of cores in mambo by changing the line: mconfig cpus CPUS 1 To do this, we need to sanitise the PIR that mambo sets and fixup the ibm,ppc-interrupt-server#s properties. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: Allow building under yocto.Patrick Williams2016-04-175-9/+4
| | | | | | | | | | | | | | | | | | | | The makefiles under external/* utilize the $(CROSS_COMPILE) variable to determine the cross-compiler prefix. In a few places, $(CROSS_COMPILE)gcc is called instead of $(CC). The issue with this is that yocto build passes some compile flags as part of $(CC) instead of $(CFLAGS), the most important of these is '--sysroot=...'. Without the proper --sysroot flag, pflash compile fails to find critical libc headers like stdio.h. This change delegates setting of $(CC) and $(LD) to external/common/rules.mk, which is widely used in the external tree, and ensures that: 1) $(CC) is used instead of $(CROSS_COMPILE)gcc. 2) CC is only set when not passed from the environment. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* boot-tests: force booting from primary (non-golden) sideStewart Smith2016-04-013-0/+12
| | | | | | | | | | Some machines decide to go boot from the Golden side, and this means we are not boot testing what we flash. So, use the magic incantation and goat sacrifice that is IPMI raw commands to boot from the primary side. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: improve xscom commands MakefileCédric Le Goater2016-04-014-13/+53
| | | | | | | | | The current Makefile is a bit rustic compared to other skiboot tools. This patch adds a proper install target and a new versioning target. Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: fix exit code in xscom commandsCédric Le Goater2016-04-013-15/+15
| | | | | | | | | commit 618a201ebf33 ("external: simplify help output in xscom commands") broke the exit code in some paths. Fixes: 618a201ebf33 Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* opal-prd: fix make test dependencies for common symlink generationStewart Smith2016-03-311-1/+1
| | | | | Fixes: e42206bf0729782330778e77283af2aca23499dc Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Make links target reusableDinar Valeev2016-03-314-63/+29
| | | | | | | | | Move symlinking target to external/common/rules.mk, so the rule could be reused by gard and opal-prd. Signed-off-by: Dinar Valeev <dvaleev@suse.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/common: Fix callers of file_init_path()Cyril Bur2016-03-312-3/+6
| | | | | | | | | | | | | | | | | | | | | The arch_flash_init() in arch_flash_x86.c doesn't actually check the return value of file_init_path(), rather it is comparing the returned structure against NULL. It is unsafe (and incorrect at the moment) to assume that file_init_path will NULL this value on failure, it doesn't have to as it returns a value to indicate success or failure. The arch_flash_init() in arch_flash_powerpc.c calls file_init_path() through another function which will return a pointer (or NULL on failure), this function doesn't explicitly NULL its return pointer in the case that file_init_path() fails. It has initialised the pointer to NULL so the case may be less severe (compared to the arch_flash_x86 problem) as file_init_path() shouldn't have changed it on failure case, however, assuming that it won't is unsafe. It is best to explicitly NULL the return pointer if file_init_path() returns a failure. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: use skiboot make_version scriptCédric Le Goater2016-03-314-17/+6
| | | | | | | | | | Let's version like skiboot and other external tools do. There is no need to generate a version.c file. Defining VERSION on the compile commande line is enough. Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> [stewart@linux.vnet.ibm.com: fix makefile CFLAGS so can be overwritten] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: simplify help output in xscom commandsCédric Le Goater2016-03-313-45/+19
| | | | | | | | This kills a few booleans used to output version and help. Suggested-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: add copyright to xscom filesCédric Le Goater2016-03-314-0/+64
| | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Add a getsram commandCédric Le Goater2016-03-314-2/+261
| | | | | | | | | The getsram command reads the OCC SRAM. This is useful for debug. The code is totally inspired from the meltbox tool. Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* getscom: Add Naples chip supportCédric Le Goater2016-03-091-0/+3
| | | | | Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* opal-prd: Add debug output for firmware-driven OCC eventsJeremy Kerr2016-03-081-0/+4
| | | | | | | | We indicate when we have a user-driven event, so add corresponding outputs for firmware-driven ones too. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/opal-prd: Make compilation prerequisites as order-only prerequisitesVasant Hegde2016-02-241-1/+1
| | | | | | | | | | Makefile creates symbolic link to libflash, ccan, etc. Presently we added them as normal prerequisites. In some cases (like we compile skiboot after compiling opal-prd) it will result in recompiling source again during make install. Hence make it as order-only prerequisites. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Add --mtdCyril Bur2016-02-233-38/+147
| | | | | | | | | | | | | | | | | | | The current behaviour of --bmc is to take over the flash controller. This flag was written for very early bring-up when the BMC stack would run entirely out of RAM. This is no longer the case and using --bmc on a BMC running out of the very flash --bmc will read is extremely likely to brick the system. It has come to light that there is some requirement to read BMC flash and some thinking that pflash is the appropriate tool. As AMI BMC firmware exposes the flash through /dev/mtd and pflash can be easily taught to read from MTD pflash can be upgraded to be the tool for the job. In order to preserve the current behavior of the --bmc a new flag --mtd has been introduced to have pflash access BMC flash the 'safe' way. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Add Makefile targets to install libflashSamuel Mendoza-Jonas2016-01-152-0/+76
| | | | | | | | | | This adds a Makefile under external/shared to build libflash as a shared library and install it. This allows programs outside of the skiboot tree to link against libflash in order to access MTD devices (eg. Petitboot). Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Drop LDFLAGS from common/rules.mkCyril Bur2016-01-151-1/+1
| | | | | Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/opal-prd: Use libflash/blocklevel for MTD/file accessesCyril Bur2016-01-155-198/+60
| | | | | | | | | | | | | | | pnor.c existed before blocklevel, it is time that this code got updated to use the available libraries. Changes include using the blocklevel accessors for MTD reads and writes rather than read() and write() on a file descriptor. This patch also makes use of the arch_flash_init() auto detection of the /dev/mtd device which corresponds to the MTD device exposed by skiboot for access to platform flash. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/opal-prd: Fix test_pnorCyril Bur2016-01-152-1/+11
| | | | | Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* libflash/blocklevel: Add keep_alive parameterCyril Bur2016-01-156-11/+12
| | | | | | | | | | | | | | | | | | Currently the file backend will keep a file descriptor open until the structure is destroyed. This is undesirable for daemons and long running processes that only have a very occasional need to access the file. Keeping the file open requires users of blocklevel to close and reinit their structures every time, doing is isn't disastrous but can easily be managed at the interface level. This has been done at the blocklevel_device interface so as to provide minimal changes to arch_flash_init(). At the moment there isn't a need for the actually flash driver to be able to do this, this remains unimplmented there. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/mambo: Load skiboot already offsetMichael Neuling2016-01-151-2/+2
| | | | | | | | Load skiboot already offset at 768MB so that it doesn't need to relocate itself. This shaves about 1M instructions off boot time. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/mambo: Fix indentation in mambo_tuils.tclMichael Neuling2016-01-151-75/+75
| | | | | | | No code change. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/gard: Fix displaying 'cleared' gard recordsCyril Bur2016-01-151-3/+33
| | | | | | | | | | | | | | | | | When a garded component is replaced hostboot detects this and updates the gard partition. What hostboot does is set the record_id field to 0xFFFFFFFF but leaves the rest of the flash untouched, this has caused issues with the gard tool the thinking was that an entire record of all 0xFF bytes would signal not a valid record. This patch add rectifies this issue and `gard list` will no longer show any record with an id of 0xFFFFFFFF. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Reviewed-by: Sam Mendoza-Jonas <sam@mendozajonas.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/opal-prd: Drop final use of ffs_open_image()Cyril Bur2016-01-081-1/+9
| | | | | | | | | | | | ffs_open_image() is only called from one place and its function has been superseded by the blocklevel_device interface to access files/mtd/flash. Ultimately it looks like opal-prd should be converted to use the full set of features provided by blocklevel but for now this patch allows code to be ripped out of libffs. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Merge branch 'stable'Stewart Smith2015-12-141-0/+1
|\
| * external/opal-prd: Set initial size valueJeremy Kerr2015-12-141-0/+1
| | | | | | | | | | | | | | | | We're not initialising 'size' in handle_prd_control_run_cmd. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | Merge branch 'stable'Stewart Smith2015-12-141-1/+1
|\|
| * external/common: Fix grammar in arch_flash error messageSamuel Mendoza-Jonas2015-12-141-1/+1
| | | | | | | | | | Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | external/pflash: Fix makefile dependenciesJoel Stanley2015-12-042-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building under buildroot, libflash was being built before the links: make[2]: *** No rule to make target 'libflash/libflash.c', needed by 'libflash-libflash.o'. Stop. make[2]: *** Waiting for unfinished jobs.... LN ccan LN common LN libflash To reproduce this outside of buildroot, set PFLASH_VERSION to anything. This is another race that is only exposed in certain conditions. By describing the dependencies on the source files the build works again. I think it's almost time to stop using symlinks. Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* | Merge branch 'stable'Stewart Smith2015-12-031-0/+52
|\|
OpenPOWER on IntegriCloud