summaryrefslogtreecommitdiffstats
path: root/external
Commit message (Collapse)AuthorAgeFilesLines
...
* opal-prd: remove unused socket file.Rafael Fonseca2016-10-282-10/+0
| | | | | Signed-off-by: Rafael Fonseca <rdossant@redhat.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Make MTD accesses the defaultCyril Bur2016-10-251-24/+22
| | | | | | | | | | | Now that BMC and host kernel mtd drivers exist and have matured we should use them by default. This is especially important since we seem to be telling everyone to use pflash. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Catch incompatible combination of flagsCyril Bur2016-10-251-0/+10
| | | | | Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/common: Rename arch_flash_bmc() to arch_flash_access()Cyril Bur2016-10-255-13/+31
| | | | | | | | | | | | | | | Honestly the first name was terrible. Initially this was intended only to serve for BMC/ARM flash access, however, it should be more generic as it is in the external/common arch code it should play nice on all architectures. This change also paves the way to change the default flash access methods in pflash. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Acked-by: Joel Stanley <joel@jms.id.au> [stewart@linux.vnet.ibm.com: preserve Joel's ack] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/common: arm: Don't error trying to wrprotect with MTD accessCyril Bur2016-10-251-0/+3
| | | | | | | | | | | | If the access method to the flash is PNOR_MTD or BMC_MTD then the actual access is being done for us by the kernel. This means we don't need to worry about wrprotecting. The arch level shouldn't be returning an error, it should be fall though. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Acked-by: Joel Stanley <joel@jms.id.au> [stewart@linux.vnet.ibm.com: preserve Joel's ack] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Advertise available RADIX page sizesChris Smart2016-10-171-2/+16
| | | | | | | | | | | | | | | | | | | | | | This adds a device tree entry which advertises additional support for 2M and 1G pages in a PAPR compliant manner. Without this, the kernel will default to only 4K and 64K page sizes. With this patch, 1G (0x40000000) pages for linear mapping will be used. This can be seen by when checking the output of "Mapping range" in the kernel log: # dmesg |grep "Mapping range" Mapping range 0x0 - 0x100000000 with 0x40000000 Without this patch, the kernel will use 64K (0x10000) instead: # dmesg |grep "Mapping range" Mapping range 0x0 - 0x100000000 with 0x10000 Signed-off-by: Chris Smart <chris@distroguy.com> Acked-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Remove unused filesCyril Bur2016-10-172-372/+0
| | | | | Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Reduce variable scope as indicated by cppcheckCyril Bur2016-10-171-4/+8
| | | | | Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/pflash: Fix ccpcheck warnings in progress.cCyril Bur2016-10-171-3/+3
| | | | | | | | | | Warnings in progress.c are not critical but warn about %d being used in printf format string when the parameter passed is unsigned. Trivial fixup which should silence the warnings. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* v2 mambo: Add section for kernel command line boot argsChris Smart2016-10-111-0/+4
| | | | | | | | | | | | Users can set kernel command line boot arguments for Mambo in a tcl script. This adds a place holder at the bottom of the skiboot.tcl script so that users know what format to use. Signed-off-by: Chris Smart <chris@distroguy.com> Acked-by: Balbir Singh <bsingharora@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Add software STB "ROM" implementation for MamboStewart Smith2016-10-101-0/+28
| | | | | | | | Pass SKIBOOT_ENABLE_MAMBO_STB=1 as environment variable to skiboot.tcl and the tcl will enable the /ibm,secureboot node, enabling hash and signature "verification" for that mambo session. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/boot_tests: remove lid from the BMC after flashingClaudio Carvalho2016-10-101-2/+10
| | | | | | | | Usually, BMC systems doesn't have too much space for storage. This removes the lid from the BMC after the lid is flashed. Signed-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/boot_tests: add the nobooting option -NClaudio Carvalho2016-10-101-10/+21
| | | | | | | | | | This adds the -N option for BMC targets, which does not boot the firmware. The option helps in situations that we need to flash multiple partitions before booting the firmware. Signed-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/boot_tests: add arbitrary lid option -FClaudio Carvalho2016-10-102-3/+27
| | | | | | | | | | | | | | | | | | | There are situations where we want to flash a lid that isn't neither BOOTKERNEL nor PAYLOAD. That's the case for CAPP, to test secure and trusted boot patches we need to flash CAPP with different secure boot headers. This adds the -F option for BMC targets that can be used to flash an arbitrary lid. Example: '-F CAPP:cappucode.bin.sec.ecc' will flash CAPP partition with cappucode.bin.sec.ecc The eyecatch for each partition is defined in https://github/open-power/pnor.git Signed-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* occ/prd/opal-prd: Queue OCC_RESET event message to host in OpenPOWERShilpasri G Bhat2016-09-261-0/+6
| | | | | | | | | | | | | | | | | During an OCC reset cycle the system is forced to Psafe pstate. When OCC becomes active, the system has to be restored to its last pstate as requested by host. So host needs to be notified of OCC_RESET event or else system will continue to remian in Psafe state until host requests a new pstate after the OCC reset cycle. This patch defines 'OPAL_PRD_MSG_TYPE_OCC_RESET_NOTIFY' to notify OPAL when opal-prd issues OCC reset. OPAL will queue OCC_RESET message to host when it receives opal_prd_msg of type '*_OCC_RESET_NOTIFY'. Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* gard/pflash: Honor linker flags passed from the environmentFrederic Bonnard2016-09-222-2/+2
| | | | | | | | | Let use LDFLAGS from the environment for gard and pflash Debian/Ubuntu use this mechanism to do hardened builds. Signed-off-by: Frederic Bonnard <frediz@linux.vnet.ibm.com> [stewart@linux.vnet.ibm.com: also use LDFLAGS for pflash] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Utilize DESTDIR in shared makefilePatrick Williams2016-09-221-6/+6
| | | | | Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* gard: Fix Makefile race conditionPatrick Williams2016-09-221-1/+5
| | | | | | | | | | | Commit fd599965 added some dependencies in 'external/pflash' for libflash files that are created via symlink. Replicate that same behavior in 'external/gard' to prevent race conditions where we attempt to compile files from libflash before they are symlink'd. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Make POWER9 look like DD2Michael Neuling2016-09-161-1/+2
| | | | | | | | | | | | | | | | | | In a recent Linux (next) change we added support for Radix Tree Size (RTS) encodings for different POWER9 revs. Linux commit: commit 694c4951922d114e789f669deb409b2aef440ae9 Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Date: Wed Aug 24 15:03:37 2016 +0530 powerpc/mm/radix: Use different RTS encoding for different POWER9 revs In mambo, we support the DD2 encoding of RTS but the PVR we advertise is DD1. Hence Linux uses the wrong RTS encoding and we don't boot. This fixes mambo to use the POWER9 DD2 PVR encoding. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* opal-prd: Fix error code from scom_read & scom_writeBenjamin Herrenschmidt2016-09-162-6/+19
| | | | | | | | | | | | | Currently, we always return a zero value from scom_read & scom_write, so the HBRT implementation has no way of detecting errors during scom operations. This change uses the actual return value from the scom operation from the kernel instead. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* opal-prd: Add get_interface_capabilities to host interfacesJeremy Kerr2016-09-163-2/+22
| | | | | | | | | | | | | We need a way to indicate behaviour changes & fixes in the prd interface, without requiring a major version bump. This change introduces the get_interface_capabilities callback, returning a bitmask of capability flags, pertaining to 'sets' of capabilities. We currently return 0 for all. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> [stewart@linux.vnet.ibm.com: Dan Crowell says "The interface looks good to me"] Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: Don't try to write protect when writing to flash fileStewart Smith2016-09-161-1/+1
| | | | | | | When we're using a file on the filesystem as the flash device, we don't need to write protect it when we flash. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: Fix printf format warningStewart Smith2016-09-151-1/+2
| | | | | | | | pflash.c: In function ‘print_flash_info’: pflash.c:138:27: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘uint64_t {aka long unsigned int}’ [-Wformat=] printf("Total size = %dMB \n", fl_total_size >> 20); Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash and opal-prd: Fix dist-cleanBreno Leitao2016-09-142-1/+2
| | | | | | | | | | | | | | Currently pflash and opal-prd do not return to its original tree after a 'make distclean'. I understand that distclean should return the tree to its original state, so, the make can restart from scratch. On Debian[1], we need to clear these remaining file 'manually' to make the build 'reproducible' (two builds in sequence). [1] https://packages.debian.org/source/sid/skiboot Signed-off-by: Breno Leitao <breno.leitao@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* opal-prd: fix for 64-bit pnor sizesJeremy Kerr2016-09-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | Current builds of opal-prd are failing with: pnor.c: In function ‘pnor_init’: pnor.c:48:43: error: passing argument 3 of ‘blocklevel_get_info’ from incompatible pointer type [-Werror=incompatible-pointer-types] rc = blocklevel_get_info(pnor->bl, NULL, &(pnor->size), &(pnor->erasesize)); ^ In file included from ./libflash/libflash.h:21:0, from ./libflash/libffs.h:19, from pnor.c:17: ./libflash/blocklevel.h:64:5: note: expected ‘uint64_t * {aka long unsigned int *}’ but argument is of type ‘uint32_t * {aka unsigned int *}’ int blocklevel_get_info(struct blocklevel_device *bl, const char **name, uint64 ^ Commit c043065cf changed the type of PNOR sizes to a uint64_t, so we need to update our pnor code to match. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Cc: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* getscom/getsram/putscom: Parse chip-id as hexAnton Blanchard2016-09-063-3/+3
| | | | | | | | | | | | | | | | | We print the chip-id in hex (without a leading 0x), but we fail to parse that same value correctly in getscom/getsram/putscom: # getscom -l ... 80000000 | DD2.0 | Centaur memory buffer # getscom -c 80000000 201140a Error -19 reading XSCOM Fix this by assuming base 16 when parsing chip-id. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: add exception and qtrace helpersNicholas Piggin2016-09-061-0/+34
| | | | | Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: fix buffer overflow: fl_total_size uint32_t not uint64_tStewart Smith2016-09-021-1/+2
| | | | | | | | | | | | | | | | | | | This ends up being harmless bug due to memory layout. $ ./pflash -F ~/op-build/output/images/firestone.pnor -i ==31829==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000062f0 80 at pc 0x410226 bp 0x7ffedba9c950 sp 0x7ffedba9c948 WRITE of size 8 at 0x00000062f080 thread T0 #0 0x410225 in file_get_info (/home/stewart/skiboot/external/pflash/pflash+0 x410225) #1 0x40d832 in blocklevel_get_info (/home/stewart/skiboot/external/pflash/pf lash+0x40d832) #2 0x401f0c in main (/home/stewart/skiboot/external/pflash/pflash+0x401f0c) #3 0x7fc77439ab44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21 b44) #4 0x403884 (/home/stewart/skiboot/external/pflash/pflash+0x403884) Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/mambo: Update skiboot.tcl to add page-sizes nodes to device treeSuraj Jitindar Singh2016-09-021-0/+14
| | | | | | | | | | | | | | | | | | | Currently skiboot.tcl doesn't add device tree nodes ibm,processor-page-sizes or ibm,segment-page-sizes. This results in failure when trying to boot a P8 guest using kvm in mambo. Update skiboot.tcl in order to have it add these device tree nodes. The values for these properties were taken from those hard-coded into skiboot in hdata/cpu-common.c:78; the format was preserved for readability and to make it obvious where these values came from. With this change it is possible to boot a P8 kvm guest in mambo. Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com> Acked-By: Michael Neuling <mikey@neuling.org> Reviewed-by: Balbir Singh <bsingharora@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: NPU hardware procedure scriptRussell Currey2016-08-301-0/+119
| | | | | | | | | Performing NPU hardware procedures requires some config space magic. Put all that magic into a script, so you can just specify the target device and the procedure number. Signed-off-by: Russell Currey <ruscur@russell.cc> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* boot-test: give a better temp file name for boot logStewart Smith2016-08-091-1/+1
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* boot-test: Add -k and -K options to keep logs on fail or alwaysStewart Smith2016-08-091-3/+20
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* flash: Make size 64 bit safeMichael Neuling2016-08-021-1/+10
| | | | | | | | | | | | | | | | This makes the size of flash 64 bit safe so that we can have flash devices greater than 4GB. This is especially useful for mambo disks passed through to Linux. Fortunately the device tree interface and the linux device driver are 64bit safe so no changes are required there. Userspace gard and flash tools are also updated to ensure "make check" still passes. Signed-off-by: Michael Neuling <mikey@neuling.org> Reviewed-by: Cyril Bur <cyrilbur@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Adopt libtool rules for soname versioning for libflashStewart Smith2016-08-011-1/+18
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: Fix the makefileJoel Stanley2016-07-281-9/+17
| | | | | | | | | Someone was a bit too keen with the cleanups last time. Restore the ability for pflash to build in non-shared mode. Fixes: c327eddd9b29 (pflash: Clean up makefiles and resolve build race) Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Update Radix Tree Size as per ISA 3.0Michael Neuling2016-07-281-1/+1
| | | | | | | | | | | | | | | | Fix Radix Tree Size (RTS) encoding as per ISA 3.0. This is controlled via a SIM_CTRL1 bit in mambo. In Linux we recently changed to this encoding, so we no longer boot. The associated Linux commit is: commit b23d9c5b9c83c05e013aa52460f12a8365062cf4 Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Date: Fri Jun 17 11:40:36 2016 +0530 powerpc/mm/radix: Update Radix tree size as per ISA 3.0 Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: use atexit for musl compatibilityJoel Stanley2016-07-281-3/+2
| | | | | | | | | | I accidentally built myself a cross-toolchain with the musl libc. It does not support on_exit which we use to clean up in pflash. Instead use atexit with is supported by both uclibc, musl and glibc. Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* pflash: Clean up makefiles and resolve build raceJoel Stanley2016-07-273-21/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pflash build process has regressed from when the were last fixed in 6c21c4ffaf82. This patch resolves that issue and performs some cleanups: - Remove duplicated rules. Patches had moved rules into common files, but forgotten to remove them from the pflash makefiles. - Make assignements simply expanded variables where possible. Form the make manual: Functions referenced in the definition will be executed every time the variable is expanded. This makes make run slower; worse, it causes the wildcard and shell functions to give unpredictable results because you cannot easily control when they are called, or even how many times. To avoid all the problems and inconveniences of recursively expanded variables, there is another flavor: simply expanded variables. - set the 'shared' target as a dependency of the libflash objects. This was the final piece to resolve the race condition. The failed build could be reproduced by doing a `git clean -f -x` and then running the following: $ make -j 32 CROSS_COMPILE=arm-linux-gnueabi- SKIBOOT_VERSION=5.2.4 PFLASH_VERSION=5.2.4 V=1 -C external/pflash all LINKAGE=dynamic make: Entering directory '/home/joel/dev/skiboot/external/pflash' ln -sf ../../libflash ./libflash ln -sf ../../ccan ./ccan ln -sf ../common ./common cc -O2 -Wall -I. -c pflash.c -o pflash.o cc -O2 -Wall -I. -c progress.c -o progress.o make -C ../shared make[1]: Entering directory '/home/joel/dev/skiboot/external/shared' ln -sf ../../hw/ast-bmc/ast-sf-ctrl.c common/ast-sf-ctrl.c ln -sf ../../include/ast.h common/ast.h ln -sf arch_flash_arm_io.h common/io.h cc -O2 -Wall -I. -c common/arch_flash_common.c -o common-arch_flash_common.o cc -O2 -Wall -I. -c common/arch_flash_arm.c -o common-arch_flash_arm.o cc -O2 -Wall -I. -c common/ast-sf-ctrl.c -o common-ast-sf-ctrl.o cc -O2 -Wall -I. -c version.c -o version.o ld -r common-arch_flash_common.o common-arch_flash_arm.o common-ast-sf-ctrl.o -o common-arch_flash.o ln -sf ../../libflash ./libflash ln -sf ../../ccan ./ccan ln -sf ../common ./common make[1]: *** No rule to make target 'libflash/file.c', needed by 'libflash-file.o'. Stop. make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/home/joel/dev/skiboot/external/shared' rules.mk:25: recipe for target '../shared/libflash.so.skiboot-5.2.4-1-g9f13f64c322f-joel-dirty-d5873ce' failed make: *** [../shared/libflash.so.skiboot-5.2.4-1-g9f13f64c322f-joel-dirty-d5873ce] Error 2 Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* fwts/generate-fwts-olog: Fix whitespace on json.dumpsDeb McLemore2016-07-221-0/+1
| | | | | | | | | | Using the indent option on json dump extra whitespace preceeds the newline in the json separator formatting. We need to remove the extra whitespace when the indent option is used to allow clean patch application. Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Fix bt command and add little endian supportMichael Neuling2016-07-201-8/+32
| | | | | | | | | | | | | | | | | | | | This fixes the bt (back trace) command which had bit rot. It also adds little endian support. Format looks like this: systemsim % bt pc: 0x000000003007F270 lr: 0x000000003007EFAC stack:0x0000000031C03B60 0x0000000031C03BF0 stack:0x0000000031C03C00 0x0000000030022F44 stack:0x0000000031C03C90 0x0000000030023000 stack:0x0000000031C03D20 0x0000000030039540 stack:0x0000000031C03E30 0x00000000300145BC stack:0x0000000031C03F00 0x000000003000259C Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* make remaining noisy tests quietStewart Smith2016-07-121-3/+3
| | | | Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Run at fastest speed.Michael Neuling2016-07-051-2/+2
| | | | | | Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Add README.md for skiboot.tclMichael Neuling2016-07-011-0/+57
| | | | | | | | | | | | Stewart has a great blog post on getting started with mambo and skiboot. It would be better to have this content here so we can keep it in sync with the code. Original blog post here: https://www.flamingspork.com/blog/2014/12/03/running-skiboot-opal-on-the-power8-simulator/ Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* mambo: Add support for POWER9Michael Neuling2016-07-011-2/+31
| | | | | | | | Ensures the simulator is configured correctly and we advertise the right features via the device tree. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Fix ARM build failure with parallel makeBrad Bishop2016-06-271-1/+1
| | | | | | | Arch headers need to be linked in before compiling. Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external/fwts: fix regex generation for %p formatJeremy Kerr2016-06-271-1/+1
| | | | | | | | | | Currently, we're emitting a non-grouping bracket expression for %p formats, which isn't supported by regex(7). This change uses the grouping format instead. The creation of a group has no effect in the fwts olog code, so this should have no consequence on matches. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* getscom/putscom: always print full 16 digitsStewart Smith2016-06-242-2/+2
| | | | | Suggested-by: Daniel M Crowell <dcrowell@us.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* fwts/generate-fwts-olog: Fix regex matches to allow more printf formatsJeremy Kerr2016-06-211-2/+2
| | | | | | | | | | | | We currently aren't handling the 'll' length modifier, or widths starting with zero (eg %016x). The former is becase we have the shorter 'l' match in the group first (so borking on the second l). The latter is because we don't allow a leading zero on width matches. This change fixes those issues. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* Fix for typosFrederic Bonnard2016-06-2010-15/+15
| | | | | | | | | While reviewing the Debian packaging, codespell found those. Most proposed fixes are based on codespell's default dictionnary. Signed-off-by: Frederic Bonnard <frediz@linux.vnet.ibm.com> Reviewed-by: Mukesh Ojha <mukesh02@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
* external: Add dynamically linked pflashBrad Bishop2016-06-072-4/+17
| | | | | | | | Modify the $(EXE) and install target dependencies if LINKAGE=dynamic. The default remains a statically linked pflash binary. Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
OpenPOWER on IntegriCloud