summaryrefslogtreecommitdiffstats
path: root/hw/occ.c
diff options
context:
space:
mode:
authorShilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>2014-11-22 00:09:25 +0530
committerStewart Smith <stewart@linux.vnet.ibm.com>2014-11-25 17:34:23 +1100
commitc1c290227ec4111fa6c406307fd04f588280ec13 (patch)
treea5abe755bb0f126d85cd38d11c41620627fcb314 /hw/occ.c
parent94c28c57e04df684c9c09b651937d7fbc7868b84 (diff)
downloadtalos-skiboot-c1c290227ec4111fa6c406307fd04f588280ec13.tar.gz
talos-skiboot-c1c290227ec4111fa6c406307fd04f588280ec13.zip
occ: Fix the low level ACK message sent to FSP on receiving {RESET/LOAD}_OCC
Modify the FSP response message to include the status code in the status/error byte instead of adding a new word to it which is incorrect. FSP ack messages are 2 words with status in the 3rd byte of second word. Status byte is in the extra (3rd) word only on new status messages from OPAL to FSP. Code corrected based on FSP mailbox spec version 3.16. Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/occ.c')
-rw-r--r--hw/occ.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/occ.c b/hw/occ.c
index c3c61e32..8b08fd11 100644
--- a/hw/occ.c
+++ b/hw/occ.c
@@ -313,7 +313,7 @@ static void occ_do_load(u8 scope, u32 dbob_id __unused, u32 seq_id)
}
/* First queue up an OK response to the load message itself */
- rsp = fsp_mkmsg(FSP_RSP_LOAD_OCC, 0 | err);
+ rsp = fsp_mkmsg(FSP_RSP_LOAD_OCC | err, 0);
if (rsp)
rc = fsp_queue_msg(rsp, fsp_freemsg);
if (rc) {
@@ -375,7 +375,7 @@ static void occ_do_reset(u8 scope, u32 dbob_id, u32 seq_id)
}
/* First queue up an OK response to the reset message itself */
- rsp = fsp_mkmsg(FSP_RSP_RESET_OCC, 0 | err);
+ rsp = fsp_mkmsg(FSP_RSP_RESET_OCC | err, 0);
if (rsp)
rc = fsp_queue_msg(rsp, fsp_freemsg);
if (rc) {
OpenPOWER on IntegriCloud