summaryrefslogtreecommitdiffstats
path: root/hw/occ.c
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2016-06-30 13:51:32 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2016-06-30 15:51:28 +1000
commit44bdc5cdfab0bceb4e2c7eadb0deebf455daefc3 (patch)
tree738a18c8bd969dac2cafab35a0851d1d34380756 /hw/occ.c
parent79968aba9568b1f8d62c23536c642cb4c9ad0ad4 (diff)
downloadtalos-skiboot-44bdc5cdfab0bceb4e2c7eadb0deebf455daefc3.tar.gz
talos-skiboot-44bdc5cdfab0bceb4e2c7eadb0deebf455daefc3.zip
occ: FWTS annotation updates based on suggestions from Vaidy
Be a bit clearer in the impact of some of these errors. Suggested-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/occ.c')
-rw-r--r--hw/occ.c13
1 files changed, 8 insertions, 5 deletions
diff --git a/hw/occ.c b/hw/occ.c
index 25e0e415..3ce00c8e 100644
--- a/hw/occ.c
+++ b/hw/occ.c
@@ -1,4 +1,4 @@
-/* Copyright 2013-2014 IBM Corp.
+/* Copyright 2013-2016 IBM Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -105,9 +105,10 @@ static bool wait_for_all_occ_init(void)
* @fwts-label OCCInvalidHomerBase
* @fwts-advice The HOMER base address for a chip
* was not valid. This means that OCC (On Chip
- * Controller) will be non-functional. This means
- * that CPU idle states and CPU frequency scaling
- * may not be functional.
+ * Controller) will be non-functional and CPU
+ * frequency scaling will not be functional. CPU may
+ * be set to a safe, low frequency. Power savings in
+ * CPU idle or CPU hotplug may be impacted.
*/
prlog(PR_ERR,"OCC: Chip: %x homer_base is not valid\n",
chip->id);
@@ -138,7 +139,9 @@ static bool wait_for_all_occ_init(void)
* @fwts-label OCCInvalidPStateTable
* @fwts-advice The pstate table for a chip
* was not valid. This means that OCC (On Chip
- * Controller) will be non-functional. This means
+ * Controller) will be non-functional and CPU
+ * frequency scaling will not be functional. CPU may
+ * be set to a low, safe frequency. This means
* that CPU idle states and CPU frequency scaling
* may not be functional.
*/
OpenPOWER on IntegriCloud