diff options
| author | Oliver O'Halloran <oohall@gmail.com> | 2016-12-21 15:52:28 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-01-04 17:15:34 +1100 |
| commit | aa586d259b58c676d0d90f9981671438442eadbe (patch) | |
| tree | 2da08e977abc698d9aafab6881e51381be285027 /core/console.c | |
| parent | 4005c1c7215364a4b53d5304d3b5afd44f5e17a7 (diff) | |
| download | talos-skiboot-aa586d259b58c676d0d90f9981671438442eadbe.tar.gz talos-skiboot-aa586d259b58c676d0d90f9981671438442eadbe.zip | |
console: document the dummy console
The OPAL console is normally completely independent to the internal
skiboot console. The dummy console is atypical compared to the FSP and
UART backends as it interacts with both consoles. This patch just adds
a few comments to clarify the situation.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'core/console.c')
| -rw-r--r-- | core/console.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/core/console.c b/core/console.c index 05c86bb9..e132ba05 100644 --- a/core/console.c +++ b/core/console.c @@ -316,7 +316,12 @@ void memcons_add_properties(void) } /* - * Default OPAL console provided if nothing else overrides it + * The default OPAL console. + * + * In the absence of a "real" OPAL console driver we handle the OPAL_CONSOLE_* + * calls by writing into the skiboot log buffer. Reads are a little more + * complicated since they can come from the in-memory console (BML) or from the + * internal skiboot console driver. */ static int64_t dummy_console_write(int64_t term_number, int64_t *length, const uint8_t *buffer) |
