summaryrefslogtreecommitdiffstats
path: root/asm
diff options
context:
space:
mode:
authorMahesh Salgaonkar <mahesh@linux.vnet.ibm.com>2015-03-30 23:50:18 +0530
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-03-31 15:42:37 +1100
commit16f965ed2ce85eed76592a82f89964fb20bbe5c9 (patch)
treec1e5876971f65091dbde5f6c4cfb37aa2d13a5cd /asm
parent4175cff8a558e6769006b2638ed9198f088c714a (diff)
downloadtalos-skiboot-16f965ed2ce85eed76592a82f89964fb20bbe5c9.tar.gz
talos-skiboot-16f965ed2ce85eed76592a82f89964fb20bbe5c9.zip
opal: Fix an issue where partial LID load causes opal to hang.
commit c789772 introduced an asynchronous mechanism to load LID resource for FSP systems. But after this change some of the FSP based system failed to load/boot petitboot kernel. While fetching LID resource in multiple chunks, we depend on return status from FSP whether there is more data available to fetch or not. As per FSP mailbox documentation, fetch cmd returns status=2 which means, there is more data pending, and status=0 means we have reached end-of-file. But in reality FSP don't behave as per the document. It looks like we always get status=0 irrespective of whether end of file is reached or not. The old implementation (fsp_sync_msg) used to rely on (wlen < chunk) check to decide whether we reached end of file or not. Ideally, FSP folks should be fix their code as per documentation. But until they do, adding the old check back here again. Without this patch some system won't be able to boot into petitboot kernel. Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'asm')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud