diff options
| author | William A. Kennington III <wak@google.com> | 2018-05-23 17:13:29 -0700 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.ibm.com> | 2018-06-01 02:07:26 -0500 |
| commit | af7c59027d7b5f5662a8cc62d8ebef2257be9ddf (patch) | |
| tree | 02cc8862fada435be58a376cd2bd5e6a4ada22a7 | |
| parent | b23d7714b4b84b9670f4fc301daef72186f832ce (diff) | |
| download | talos-skiboot-af7c59027d7b5f5662a8cc62d8ebef2257be9ddf.tar.gz talos-skiboot-af7c59027d7b5f5662a8cc62d8ebef2257be9ddf.zip | |
ipmi-watchdog: Don't reset the watchdog twice
There is no clarification for why this change was needed, but presumably
this is due to a buggy BMC implementation where the Watchdog Set command
was processed concurrently or after the initial Watchdog Reset. This
inversion would cause the watchdog to stop since the DONT_STOP bit was
not set. Since we are now using the DONT_STOP bit during initialization,
the watchdog should not be stopped even if an inversion occurs.
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
| -rw-r--r-- | hw/ipmi/ipmi-watchdog.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/hw/ipmi/ipmi-watchdog.c b/hw/ipmi/ipmi-watchdog.c index ee160844..e8efba2b 100644 --- a/hw/ipmi/ipmi-watchdog.c +++ b/hw/ipmi/ipmi-watchdog.c @@ -143,9 +143,5 @@ void ipmi_wdt_init(void) * could crash before the wdt has actually been started. */ sync_reset_wdt(); - /* For some reason we have to reset it twice to get it to - * actually start the first time. */ - sync_reset_wdt(); - return; } |
