summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlistair Popple <alistair@popple.id.au>2014-11-05 14:40:48 +1100
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2014-11-12 16:41:26 +1100
commitcda7da4f537e88719930318a1a98da53d5268fe1 (patch)
treecc597da23a5b7d7b270e8bd6b8ce385aaf1b7a94
parent983db8cc4b6444de8df2ce1a273f3f3b9eec12c3 (diff)
downloadtalos-skiboot-cda7da4f537e88719930318a1a98da53d5268fe1.tar.gz
talos-skiboot-cda7da4f537e88719930318a1a98da53d5268fe1.zip
bt/ipmi: Quieten logging output
Some tools (eg. ipmitool) that use the Linux ipmi stack send potentially invalid commands to probe functionality. Currently skiboot prints an error to the console whenever this happens resulting in excessive noise when using the Linux ipmi stack. This patch just removes and/or lowers the logging level of these errors. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--core/ipmi.c2
-rw-r--r--hw/bt.c3
2 files changed, 1 insertions, 4 deletions
diff --git a/core/ipmi.c b/core/ipmi.c
index 28b8022a..32f1f4d1 100644
--- a/core/ipmi.c
+++ b/core/ipmi.c
@@ -87,7 +87,7 @@ void ipmi_cmd_done(uint8_t cmd, uint8_t netfn, uint8_t cc, struct ipmi_msg *msg)
msg->netfn = netfn;
if (cc != IPMI_CC_NO_ERROR) {
- prerror("IPMI: Got error response 0x%02x\n", msg->cc);
+ prlog(PR_DEBUG, "IPMI: Got error response 0x%02x\n", msg->cc);
assert(msg->error);
msg->error(msg);
diff --git a/hw/bt.c b/hw/bt.c
index c57b883c..da84da0f 100644
--- a/hw/bt.c
+++ b/hw/bt.c
@@ -275,9 +275,6 @@ static bool bt_get_resp(void)
ipmi_msg->data[i] = bt_inb(BT_HOST2BMC);
bt_set_h_busy(false);
- if (cc != IPMI_CC_NO_ERROR)
- prerror("BT: Host error 0x%02x receiving BT/IPMI response for msg 0x%02x\n", cc, seq);
-
/* Make sure the other side is idle before we move to the idle state */
bt_set_state(BT_STATE_B_BUSY);
list_del(&bt_msg->link);
OpenPOWER on IntegriCloud