summaryrefslogtreecommitdiffstats
path: root/src/import/chips/p9/xip
Commit message (Collapse)AuthorAgeFilesLines
* IOPPE image build flowMartin Peschke2017-02-011-4/+10
| | | | | | | | | | | | | | | | | | Defines IOPPE XIP image sections, creates build flow for IOPPE sub image, and makes the HW Image build flow pick up the latter. Change-Id: I4ff43a3fe556741c584cf929c86479034c4a516a Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/28320 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Claus M. Olsen <cmolsen@us.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35377 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* Removed c++11 dependencySachin Gupta2017-01-311-9/+1
| | | | | | | | | | | | | Change-Id: Ieab974da63942fab7c5f12568c5686beedf8568e Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35315 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Claus M. Olsen <cmolsen@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35383 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* TOR space reductionsMartin Peschke2017-01-251-18/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These changes avoid some waste of valuable memory used to store TOR and rings contained in TOR. This is mostly needed as a SEEPROM relief. Contains: - 12 byte ring header (former 31551 commit) - less zero padding at the end of compressed ring (former 31524 commit) - removed an additional ring meta data structure (former 31524 commit) In addition, it contains these fixes: - fixed a bunch of scan addresses (former 33969 commit) - increased size of ring decompression buffer (former 32796 commit) - zero byte ring padding up to 4 byte boundaries for SBE (former 33969 commit) - added dbgl control of error trace after call to get_ring_from_sbe_image - added enumerated ringId to the RS4v3 header - fixed incorrect scan address masks for even/odd EX RS4 v3 ring handling in MVPD accessor functions - fixed incorrect scan address region bits for odd EX rings translated from RS4 v2 to RS4 v3 in MVPD accessor functions CMVC-Prereq: 1015124 Change-Id: I8fd00760e6ac2b3760994d1ca819fffbf35188ca Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33993 Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34014 Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* Reverting RS4v3 changesSachin Gupta2016-12-201-8/+17
| | | | | | | | | | | | | | | | | Revert "TOR reduction: Ditching DeltaRingLayout and RingLayout_t" This reverts commit 0ea8cddae37eb5186571e6c66469dad694de9c5a. Revert "Shrinking RS4 header" This reverts commit c1a7c86e800e8bb38f6549b443bb4801feb4f1e3. Change-Id: I7832e23491ea34f86db3cbdc5d25c98e3a9f1821 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33985 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33990 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* TOR reduction: Ditching DeltaRingLayout and RingLayout_tClaus Michael Olsen2016-12-201-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Complete overhaul of get_ring_from_sbe_image for improved clarity in effort to remove anything related to 8Byte RingLayout header, incl built-in and hardcoded assumptions. - Functional overhaul of get_ring_from_cme/sgpe_image, but only slight improvement in clarity. Also removed any traces of RingLayout assumptions. (Beautification of these functions will be in separate commit.) - Overhaul of tor_append_ring for clarity and improved clarity elsewhere where PUT_SINGLE_RING is used. - Updated p9_tor.C|H in order to expose version 2 of TOR API, which eliminates the 8B RingLayout structure, in order to work with Cronus which currently assumes, due to pulling in the p9_tor.H header file, that RingLayout structure is being used. - Updated p9_scan_compression.C to remove most zero padding at end of compressed ring (i.e., merged commit 32647 into this commit in order to be able to merge into gerrit). - The scan compression code used to pad the compressed ring at its end with zeros up to the next 8 byte boundary. For P9, no padding is needed. Most of this padding is now removed, just keeping a padding to the next 2 byte boundary for convenience. Removal of these padding bytes saves about 400 bytes in SEEPROM. - Added p9_ipl_build.C because it assumes an 8B alignment of the SBE ring block which is no longer the case with RS4v3. We've been lucky so far in our tests. Change-Id: I08edef8e53302dab765a73dc4d6ca68cd8dce440 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31524 Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32268 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* Shrinking RS4 headerMartin Peschke2016-12-201-14/+2
| | | | | | | | | | | | | | | | | | | | | | Implements a new 12 byte CompressedScanData structure with less and refined members in order to save space for rings. Used test tool to verify correctness of p9_scan_compression changes. Used p9_xip_tool dissect to verify .rings of HW Image with new RS4 header. Change-Id: I68b3044b62908d013778f87343798ebaa6829923 RTC:158078 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31551 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Claus M. Olsen <cmolsen@us.ibm.com> Reviewed-by: Prem Shanker Jha <premjha2@in.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31968 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* xip_tool: Small fix to prevent false appearance of OVRD in dissectClaus Michael Olsen2016-11-231-1/+3
| | | | | | | | | | | | | | | summary. Change-Id: I648937c4840281d68173bba41bee70d30abd29ee Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32705 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Sumit Kumar <sumit_kumar@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32712 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* xip_tool: Minor cleanupClaus Michael Olsen2016-11-041-5/+4
| | | | | | | | | | | | | | | Change-Id: Ida5384bcd899313b9f822261a6aa1d94500e87b0 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32109 Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32120 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* Cleanup: TOR API cleaning upClaus Michael Olsen2016-10-211-9/+9
| | | | | | | | | | | | | | | | | | | | | | - Catching all abrupt ending if-elseif endings. - Updated all API comments in *.C file. - Making local functions static. - Accommodated additional six EX rings in tor_get_block_of_rings(CPLT). - Now limiting max DD levels to 20 to prevent infinite trace out loop. - Fixing bunch of inconsistent error return code situations. Change-Id: I516c9554836b32a7717ef626afcba0cf4c03d6bf Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/30798 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Joachim Fenkes <fenkes@de.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/30839 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* P9-XIP: simplify p9_xip_get_scalar()Martin Peschke2016-10-041-16/+6
| | | | | | | | | | | | | | | | Removing code duplication Change-Id: I7708a9016c2a8679454c26df87dab350e7443df6 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29765 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29773 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* P9-XIP: simplify p9_xip_get_element()Martin Peschke2016-10-041-60/+5
| | | | | | | | | | | | | | | Removing code duplication Change-Id: I8afb0a03f3b4a3bd8590419b0c1e9ff8e051fe5a Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29764 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29771 Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
* p9_xip_tool: fix lost changeMartin Peschke2016-09-201-16/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The p9_xip_tool source file was renamed from .c to .C some months ago. Unfortunately, a lot of changes were made at the same time, and the author based their work on an outdated version of the original file. As a result, a change merged into the original file got lost. This patch adds the erroneously deleted change back in. Commit that was lost and is added back in: 6b1c327dfc190bfa9585825a672e10c30210a4c7 "P9-XIP: improved image reports" Commit that deletes the original .c file: fff71ea814b0e942ffc999d065f7cd3bc4f1672f Commit that adds the new .C file: f50099fed8593a9079dda2bf6e6637a00e946218 Change-Id: I1aa8fb9bd0ce069875e64b213f10365258af5f9a Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29835 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Claus M. Olsen <cmolsen@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29838 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* p9_xip_tool: print attribute arrays in reportMartin Peschke2016-09-201-47/+61
| | | | | | | | | | | | | | | | | | | Some attributes inside .fixed are actually arrays of values. So print each values. Handles both plain XIP images as well as PIBMEM dumps. Change-Id: Ic5b346a33a8da70b3f2caf1737521446b85e0061 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29758 Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Shakeeb A. Pasha B K <shakeebbk@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29762 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* P9-XIP: p9_xip_get_item() can now deal with array attributesMartin Peschke2016-09-203-12/+24
| | | | | | | | | | | | | | | | | | This is a new API only used in one place so far. So enhancing it should be ok. The funtionality is needed for a p9_xip_tool change. Change-Id: Ibecb2ee45dc5fbf1394fcac0bfef92aa10468927 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29752 Reviewed-by: Shakeeb A. Pasha B K <shakeebbk@in.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29755 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* p9_xip_tool: static routines and unused code cleanupMartin Peschke2016-09-201-37/+16
| | | | | | | | | | | | | | | | | | Make all routines static in order to be consistent, and since there is no p9_xip_tool API. This has revealed an unused routine, which is being removed. Change-Id: I66e752a3dd3d95fcc5190a58e3f6facc3e3dfcec Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29743 Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Shakeeb A. Pasha B K <shakeebbk@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29747 Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
* p9_xip_tool: remove duplicated code in tocListing()Martin Peschke2016-09-191-162/+41
| | | | | | | | | | | | | | | | | | It is preferable to share code in attrListing(). This change prepares an enhancement inside the formerly duplicate and now shared code. Change-Id: I2aee399255fb275d3da946a69bf368b93e2e498c Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29742 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Shakeeb A. Pasha B K <shakeebbk@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29745 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* Update file headersSachin Gupta2016-09-163-3/+3
| | | | | | | | Change-Id: Icdd7460d8e3213f9bbd3d52e7825242bc59fc9e9 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29825 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* Return rc=2 breaks. fixGirisankar Paulraj2016-09-121-1/+5
| | | | | | | | | | | | | | | | | Added condition to IMGBUILD_TGR_INVALID_RING_ID for continuing xip tool dissect. this is known error for invalid id. Change-Id: I29a363a2ab2a2c01fdccb389c93db54ff2be0f4d Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29243 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Claus M. Olsen <cmolsen@us.ibm.com> Reviewed-by: SRINIVAS V. POLISETTY <srinivan@in.ibm.com> Reviewed-by: PARVATHI RACHAKONDA <prachako@in.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29244 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
* SBE move import`Shakeeb2016-09-014-0/+7827
Change-Id: I726951318cdb19fd445af2f7910e0d6872eff18c Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29086 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: AMIT J. TENDOLKAR <amit.tendolkar@in.ibm.com>
OpenPOWER on IntegriCloud