summaryrefslogtreecommitdiffstats
path: root/src/import/chips
diff options
context:
space:
mode:
Diffstat (limited to 'src/import/chips')
-rw-r--r--src/import/chips/p9/procedures/hwp/initfiles/p9_mmu_scom.C28
-rw-r--r--src/import/chips/p9/procedures/hwp/perv/p9_sbe_tracearray.C10
-rw-r--r--src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml283
-rw-r--r--src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml4
4 files changed, 151 insertions, 174 deletions
diff --git a/src/import/chips/p9/procedures/hwp/initfiles/p9_mmu_scom.C b/src/import/chips/p9/procedures/hwp/initfiles/p9_mmu_scom.C
index 8acd3c72..f1308e10 100644
--- a/src/import/chips/p9/procedures/hwp/initfiles/p9_mmu_scom.C
+++ b/src/import/chips/p9/procedures/hwp/initfiles/p9_mmu_scom.C
@@ -55,8 +55,8 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
fapi2::ATTR_NAME_Type l_chip_id;
FAPI_TRY(FAPI_ATTR_GET_PRIVILEGED(fapi2::ATTR_NAME, TGT0, l_chip_id));
FAPI_TRY(FAPI_ATTR_GET_PRIVILEGED(fapi2::ATTR_EC, TGT0, l_chip_ec));
- fapi2::ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2_Type l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2;
- FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2, TGT0, l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2));
+ fapi2::ATTR_CHIP_EC_FEATURE_NMMU_NDD1_Type l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1;
+ FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_NMMU_NDD1, TGT0, l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1));
fapi2::ATTR_PROC_FABRIC_PUMP_MODE_Type l_TGT1_ATTR_PROC_FABRIC_PUMP_MODE;
FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_PROC_FABRIC_PUMP_MODE, TGT1, l_TGT1_ATTR_PROC_FABRIC_PUMP_MODE));
fapi2::ATTR_PROC_EPS_WRITE_CYCLES_T1_Type l_TGT1_ATTR_PROC_EPS_WRITE_CYCLES_T1;
@@ -67,11 +67,11 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
{
FAPI_TRY(fapi2::getScom( TGT0, 0x5012c03ull, l_scom_buffer ));
- if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 == literal_0))
+ if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 != literal_0))
{
l_scom_buffer.insert<0, 22, 0, uint64_t>(literal_0x04047C0000000000 );
}
- else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 != literal_0))
+ else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 == literal_0))
{
l_scom_buffer.insert<0, 22, 0, uint64_t>(literal_0x04247C0000000000 );
}
@@ -87,11 +87,11 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
{
FAPI_TRY(fapi2::getScom( TGT0, 0x5012c07ull, l_scom_buffer ));
- if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 == literal_0))
+ if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 != literal_0))
{
l_scom_buffer.insert<0, 22, 0, uint64_t>(literal_0x409B000000000000 );
}
- else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 != literal_0))
+ else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 == literal_0))
{
l_scom_buffer.insert<0, 22, 0, uint64_t>(literal_0x40FB000000000000 );
}
@@ -134,11 +134,11 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
{
FAPI_TRY(fapi2::getScom( TGT0, 0x5012c43ull, l_scom_buffer ));
- if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 == literal_0))
+ if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 != literal_0))
{
l_scom_buffer.insert<0, 48, 16, uint64_t>(literal_0x0000FAF800FF );
}
- else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 != literal_0))
+ else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 == literal_0))
{
l_scom_buffer.insert<0, 48, 16, uint64_t>(literal_0x0000FAFC00FB );
}
@@ -154,11 +154,11 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
{
FAPI_TRY(fapi2::getScom( TGT0, 0x5012c47ull, l_scom_buffer ));
- if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 == literal_0))
+ if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 != literal_0))
{
l_scom_buffer.insert<0, 48, 16, uint64_t>(literal_0x910000040F00 );
}
- else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 != literal_0))
+ else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 == literal_0))
{
l_scom_buffer.insert<0, 48, 16, uint64_t>(literal_0x9D1100000F04 );
}
@@ -171,11 +171,11 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
l_scom_buffer.insert<30, 1, 59, uint64_t>(literal_0b11111 );
l_scom_buffer.insert<60, 4, 60, uint64_t>(literal_0b11111 );
- if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 == literal_0))
+ if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 != literal_0))
{
l_scom_buffer.insert<0, 12, 52, uint64_t>(literal_0x00E );
}
- else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 != literal_0))
+ else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 == literal_0))
{
l_scom_buffer.insert<0, 12, 52, uint64_t>(literal_0x000 );
}
@@ -227,12 +227,12 @@ fapi2::ReturnCode p9_mmu_scom(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>&
l_scom_buffer.insert<44, 8, 56, uint64_t>(l_NMMU_MM_MPSS_MODE_MPSS_ENA_PREF_PGSZ_ENA_G_64KB_H_64KB );
}
- if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 == literal_0))
+ if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 != literal_0))
{
constexpr auto l_NMMU_MM_CFG_NMMU_CTL_TLB_HASH_PID_DIS_ON = 0x1;
l_scom_buffer.insert<21, 1, 63, uint64_t>(l_NMMU_MM_CFG_NMMU_CTL_TLB_HASH_PID_DIS_ON );
}
- else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2 != literal_0))
+ else if ((l_TGT0_ATTR_CHIP_EC_FEATURE_NMMU_NDD1 == literal_0))
{
constexpr auto l_NMMU_MM_CFG_NMMU_CTL_TLB_HASH_PID_DIS_OFF = 0x0;
l_scom_buffer.insert<21, 1, 63, uint64_t>(l_NMMU_MM_CFG_NMMU_CTL_TLB_HASH_PID_DIS_OFF );
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tracearray.C b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tracearray.C
index 4f1e4ca6..8502501c 100644
--- a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tracearray.C
+++ b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tracearray.C
@@ -249,16 +249,16 @@ fapi2::ReturnCode p9_sbe_tracearray(
* Check an EC feature to see if that's fixed. */
if (ta_type == fapi2::TARGET_TYPE_CORE)
{
- uint8_t l_core_trace_scomable = 0;
+ uint8_t l_core_trace_not_scomable = 0;
fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP> proc_target =
i_target.getParent<fapi2::TARGET_TYPE_PROC_CHIP>();
- FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_CORE_TRACE_SCOMABLE,
- proc_target, l_core_trace_scomable),
+ FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_CORE_TRACE_NOT_SCOMABLE,
+ proc_target, l_core_trace_not_scomable),
"Failed to query chip EC feature "
- "ATTR_CHIP_EC_FEATURE_CORE_TRACE_SCOMABLE");
+ "ATTR_CHIP_EC_FEATURE_CORE_TRACE_NOT_SCOMABLE");
- if (!l_core_trace_scomable)
+ if (l_core_trace_not_scomable)
{
FAPI_ERR("Core arrays cannot be dumped in this chip EC; "
"please use fastarray instead.");
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml
index 0913557b..e6d991be 100644
--- a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml
@@ -31,11 +31,10 @@
<attributes>
<!-- ********************************************************************* -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_P9N_DD1_SPY_NAMES</id>
+ <id>ATTR_CHIP_EC_FEATURE_P9_NO_NDL_IOVALID</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Returns true if spy name has changed from dd1 to dd2.
- Less than Nimbus ec 0x20
+ Returns true if the chip has no NDL IOValid bits
</description>
<chipEcFeature>
<chip>
@@ -49,42 +48,6 @@
</attribute>
<!-- ********************************************************************* -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_P9N_DD2_SPY_NAMES</id>
- <targetType>TARGET_TYPE_PROC_CHIP</targetType>
- <description>
- Returns true if spy name has changed from dd1 to dd2.
- Greater than or equal to 0x20
- </description>
- <chipEcFeature>
- <chip>
- <name>ENUM_ATTR_NAME_NIMBUS</name>
- <ec>
- <value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- </chipEcFeature>
- </attribute>
- <!-- ********************************************************************* -->
- <attribute>
- <id>ATTR_CHIP_EC_FEATURE_P9_NDL_IOVALID</id>
- <targetType>TARGET_TYPE_PROC_CHIP</targetType>
- <description>
- Returns true if the chip has NDL IOValid bits
- P9N dd2
- </description>
- <chipEcFeature>
- <chip>
- <name>ENUM_ATTR_NAME_NIMBUS</name>
- <ec>
- <value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- </chipEcFeature>
- </attribute>
- <!-- ********************************************************************* -->
- <attribute>
<id>ATTR_CHIP_EC_FEATURE_EARLYMODE_FIX</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
@@ -102,18 +65,18 @@
</attribute>
<!-- ********************************************************************* -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_CORE_TRACE_SCOMABLE</id>
+ <id>ATTR_CHIP_EC_FEATURE_CORE_TRACE_NOT_SCOMABLE</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Returns true if the core trace arrays are dumpable via SCOM.
- Nimbus EC 0x20 or greater
+ Returns true if the core trace arrays are not dumpable via SCOM.
+ Nimbus EC 0x10
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
+ <test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
@@ -1690,24 +1653,17 @@
</attribute>
<!-- ********************************************************************* -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2</id>
+ <id>ATTR_CHIP_EC_FEATURE_NMMU_NDD1</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Sets inits for DD2, also DMT mode
+ Configure NMMU for Nimbus DD1
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- <chip>
- <name>ENUM_ATTR_NAME_CUMULUS</name>
- <ec>
- <value>0x10</value>
- <test>GREATER_THAN_OR_EQUAL</test>
+ <test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
@@ -1748,24 +1704,18 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_NMMU_ISS734_DD2_1</id>
+ <id>ATTR_CHIP_EC_FEATURE_NMMU_NOT_ISS734</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- issue734 dial, exists dd2.1+
+ NMMU does not require application of issue734 fixes
+ Issue734 exists on Nimbus dd2.1+
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x21</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- <chip>
- <name>ENUM_ATTR_NAME_CUMULUS</name>
- <ec>
- <value>0x10</value>
- <test>GREATER_THAN_OR_EQUAL</test>
+ <test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
@@ -2001,7 +1951,7 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_HW396230_SCAN_ONLY</id>
+ <id>ATTR_CHIP_EC_FEATURE_HW396230</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Nimbus DD1 only: set L3/NCU skip group scope via scan only
@@ -2018,30 +1968,6 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_HW396230_SCOM</id>
- <targetType>TARGET_TYPE_PROC_CHIP</targetType>
- <description>
- Nimbus DD2+: able to set L3/NCU skip group scope via SCOM
- </description>
- <chipEcFeature>
- <chip>
- <name>ENUM_ATTR_NAME_NIMBUS</name>
- <ec>
- <value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- <chip>
- <name>ENUM_ATTR_NAME_CUMULUS</name>
- <ec>
- <value>0x10</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- </chipEcFeature>
- </attribute>
- <!-- ******************************************************************** -->
- <attribute>
<id>ATTR_CHIP_EC_FEATURE_HW405880_LCO_IN_RETENTION</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
@@ -2060,10 +1986,10 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_OPTIMAL_LCO_SCAN_ONLY</id>
+ <id>ATTR_CHIP_EC_FEATURE_HW386657</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Nimbus DD1 only: set the optimal dial setups for LCO's
+ Nimbus DD1 only: set the optimal dial setups for LCO's via scan
</description>
<chipEcFeature>
<chip>
@@ -2077,30 +2003,6 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_OPTIMAL_LCO_SCOM</id>
- <targetType>TARGET_TYPE_PROC_CHIP</targetType>
- <description>
- Nimbus DD2+: set the optimal dial setups for LCO's
- </description>
- <chipEcFeature>
- <chip>
- <name>ENUM_ATTR_NAME_NIMBUS</name>
- <ec>
- <value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- <chip>
- <name>ENUM_ATTR_NAME_CUMULUS</name>
- <ec>
- <value>0x10</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- </chipEcFeature>
- </attribute>
- <!-- ******************************************************************** -->
- <attribute>
<id>ATTR_CHIP_EC_FEATURE_DISABLE_CP_ME</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
@@ -2118,31 +2020,24 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_OPTIMAL_LARX_STCX_PERF</id>
+ <id>ATTR_CHIP_EC_FEATURE_UNTUNED_LARX_STCX_PERF</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Nimbus DD2+: set the optimal dial setups for larx/stcx
+ Nimbus DD1: Larx/stcx dials are non performance tuned
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- <chip>
- <name>ENUM_ATTR_NAME_CUMULUS</name>
- <ec>
- <value>0x10</value>
- <test>GREATER_THAN_OR_EQUAL</test>
+ <test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_HW409069</id>
+ <id>ATTR_CHIP_EC_FEATURE_NOT_HW409069</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Nimbus DD2+: HW409069 load_larx protection not activated because of dtag_data_resp
@@ -2153,14 +2048,7 @@
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- <chip>
- <name>ENUM_ATTR_NAME_CUMULUS</name>
- <ec>
- <value>0x10</value>
- <test>GREATER_THAN_OR_EQUAL</test>
+ <test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
@@ -2839,6 +2727,113 @@
</chipEcFeature>
</attribute>
+ <attribute>
+ <id>ATTR_CHIP_EC_FEATURE_HW391162</id>
+ <targetType>TARGET_TYPE_PROC_CHIP</targetType>
+ <description>
+ Nimbus DD1 only: spoof pb_init in cache contained mode
+ Enables L2 checkers to monitor for transactions arbitrating
+ to broadcast onto the fabric
+ </description>
+ <chipEcFeature>
+ <chip>
+ <name>ENUM_ATTR_NAME_NIMBUS</name>
+ <ec>
+ <value>0x20</value>
+ <test>LESS_THAN</test>
+ </ec>
+ </chip>
+ </chipEcFeature>
+ </attribute>
+
+ <attribute>
+ <id>ATTR_CHIP_EC_FEATURE_SCAN_SICR_TLBIE_QUIESCE</id>
+ <targetType>TARGET_TYPE_PROC_CHIP</targetType>
+ <description>
+ Nimbus DD1 only: scan ON NCU_TLBIE_QUISCE fence
+ for non-cache contained modes. Flush state corrected in HW
+ for future revisions
+ </description>
+ <chipEcFeature>
+ <chip>
+ <name>ENUM_ATTR_NAME_NIMBUS</name>
+ <ec>
+ <value>0x20</value>
+ <test>LESS_THAN</test>
+ </ec>
+ </chip>
+ </chipEcFeature>
+ </attribute>
+
+ <attribute>
+ <id>ATTR_CHIP_EC_FEATURE_CXA_P9NDD1_SPY_NAMES</id>
+ <targetType>TARGET_TYPE_PROC_CHIP</targetType>
+ <description>
+ Use Nimbus DD1 CXA spy register definition names
+ </description>
+ <chipEcFeature>
+ <chip>
+ <name>ENUM_ATTR_NAME_NIMBUS</name>
+ <ec>
+ <value>0x20</value>
+ <test>LESS_THAN</test>
+ </ec>
+ </chip>
+ </chipEcFeature>
+ </attribute>
+
+ <attribute>
+ <id>ATTR_CHIP_EC_FEATURE_DDRPHY_P9NDD1_SPY_NAMES</id>
+ <targetType>TARGET_TYPE_PROC_CHIP</targetType>
+ <description>
+ Use Nimbus DD1 DDR PHY spy register definition names
+ </description>
+ <chipEcFeature>
+ <chip>
+ <name>ENUM_ATTR_NAME_NIMBUS</name>
+ <ec>
+ <value>0x20</value>
+ <test>LESS_THAN</test>
+ </ec>
+ </chip>
+ </chipEcFeature>
+ </attribute>
+
+ <attribute>
+ <id>ATTR_CHIP_EC_FEATURE_MCA_P9NDD1_ASYNC</id>
+ <targetType>TARGET_TYPE_PROC_CHIP</targetType>
+ <description>
+ Program MCA ECC logic to support Nimbus DD1
+ asynchronus boundary crossing requirements
+ </description>
+ <chipEcFeature>
+ <chip>
+ <name>ENUM_ATTR_NAME_NIMBUS</name>
+ <ec>
+ <value>0x20</value>
+ <test>LESS_THAN</test>
+ </ec>
+ </chip>
+ </chipEcFeature>
+ </attribute>
+
+ <attribute>
+ <id>ATTR_CHIP_EC_FEATURE_CORE_P9NDD1</id>
+ <targetType>TARGET_TYPE_PROC_CHIP</targetType>
+ <description>
+ Nimbus DD1 core spy behavior qualifier
+ </description>
+ <chipEcFeature>
+ <chip>
+ <name>ENUM_ATTR_NAME_NIMBUS</name>
+ <ec>
+ <value>0x20</value>
+ <test>LESS_THAN</test>
+ </ec>
+ </chip>
+ </chipEcFeature>
+ </attribute>
+
<!-- ******************************************************************** -->
<!-- Memory Section -->
<!-- ******************************************************************** -->
@@ -3215,7 +3210,7 @@
<id>ATTR_CHIP_EC_FEATURE_HW404176_ASSERT_SCAN_CLK</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Only MC in Cumulus need to generate scan clock in even cycle instead of odd
+ Cumulus only: MC chiplet requires scan clock in even cycle instead of odd
</description>
<chipEcFeature>
<chip>
@@ -3232,7 +3227,7 @@
<id>ATTR_CHIP_EC_FEATURE_HW406337</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
- Cumulus only dropping MC chiplet fence during arrayinit
+ Cumulus only: dropping MC chiplet fence during arrayinit
</description>
<chipEcFeature>
<chip>
@@ -3337,24 +3332,6 @@
</attribute>
<!-- ******************************************************************** -->
<attribute>
- <id>ATTR_CHIP_EC_FEATURE_POSTDD1N_DPLL_SETTINGS</id>
- <targetType>TARGET_TYPE_PROC_CHIP</targetType>
- <description>
- Post DD1 update : Used for new DD2 settings such as ..._EXTERNAL_JUMP_VALUES latch is new for DD2. True if:
- Nimbus EC greater than or equal to 20
- </description>
- <chipEcFeature>
- <chip>
- <name>ENUM_ATTR_NAME_NIMBUS</name>
- <ec>
- <value>0x20</value>
- <test>GREATER_THAN_OR_EQUAL</test>
- </ec>
- </chip>
- </chipEcFeature>
- </attribute>
- <!-- ******************************************************************** -->
- <attribute>
<id>ATTR_CHIP_EC_FEATURE_INT_DD1</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml
index cac558af..e00c1e77 100644
--- a/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml
@@ -326,7 +326,7 @@ attribute tank
<!-- Pervasive EC attributes -->
<entry>
- <name>ATTR_CHIP_EC_FEATURE_CORE_TRACE_SCOMABLE</name>
+ <name>ATTR_CHIP_EC_FEATURE_CORE_TRACE_NOT_SCOMABLE</name>
<virtual/>
</entry>
<entry>
@@ -401,7 +401,7 @@ attribute tank
</entry>
<entry>
- <name>ATTR_CHIP_EC_FEATURE_NMMU_DMT_DD2</name>
+ <name>ATTR_CHIP_EC_FEATURE_NMMU_NDD1</name>
<virtual/>
</entry>
<entry>
OpenPOWER on IntegriCloud