diff options
| author | Doug Gilbert <dgilbert@us.ibm.com> | 2016-10-13 13:59:53 -0500 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2016-11-23 23:14:54 -0500 |
| commit | 4d9e06f89702dd907a209b0ce9cb9fa36858d8cd (patch) | |
| tree | 8cce47a1c23de9dd67788f732027b3b031e342ce /src/sbefw/sbecmdregaccess.C | |
| parent | 24f6d36ca47af190b6246d22401805ffd2df7c2a (diff) | |
| download | talos-sbe-4d9e06f89702dd907a209b0ce9cb9fa36858d8cd.tar.gz talos-sbe-4d9e06f89702dd907a209b0ce9cb9fa36858d8cd.zip | |
Fix some trace problems
This change is in preparation for future, better trace handling.
Bit fields don't have a size_type - so they need a cast to int or uint in a
trace statement.
Pointers are always 4 bytes in PPE.
Pointers cannot be converted to a uint32_t (%x) without an explicit cast.
The printf/trace format %x is 4 bytes, even %016x is 4 bytes. What is
needed is %llx or %016llx otherise a uint64_t will get truncated.
Change-Id: I0b55a355f3211a7f6913e846834486b4808f50c1
RTC: 161851
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31189
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src/sbefw/sbecmdregaccess.C')
| -rw-r--r-- | src/sbefw/sbecmdregaccess.C | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/sbefw/sbecmdregaccess.C b/src/sbefw/sbecmdregaccess.C index 57492c59..dd5f4e89 100644 --- a/src/sbefw/sbecmdregaccess.C +++ b/src/sbefw/sbecmdregaccess.C @@ -109,7 +109,7 @@ uint32_t sbeGetReg(uint8_t *i_pArg) if( fapiRc != FAPI2_RC_SUCCESS ) { SBE_ERROR(SBE_FUNC" ram_setup failed. threadNr:0x%x" - "chipletId:0x%02x", regReqMsg.threadNr, core); + "chipletId:0x%02x", (uint32_t)regReqMsg.threadNr, core); respHdr.setStatus( SBE_PRI_GENERIC_EXECUTION_FAILURE, SBE_SEC_GENERIC_FAILURE_IN_EXECUTION); ffdc.setRc(fapiRc); @@ -152,7 +152,7 @@ uint32_t sbeGetReg(uint8_t *i_pArg) if( fapiRc != FAPI2_RC_SUCCESS ) { SBE_ERROR(SBE_FUNC" ram_cleanup failed. threadNr:0x%x" - "chipletId:0x%02x", regReqMsg.threadNr, core); + "chipletId:0x%02x", (uint32_t)regReqMsg.threadNr, core); respHdr.setStatus( SBE_PRI_GENERIC_EXECUTION_FAILURE, SBE_SEC_GENERIC_FAILURE_IN_EXECUTION); ffdc.setRc(fapiRc); @@ -197,8 +197,10 @@ uint32_t sbePutReg(uint8_t *i_pArg) if( false == regReqMsg.isValidRequest() ) { SBE_ERROR(SBE_FUNC" Invalid request. threadNr:0x%x" - " regType:0x%02x numRegs:0x%02x", regReqMsg.threadNr, - regReqMsg.regType, regReqMsg.numRegs); + " regType:0x%02x numRegs:0x%02x", + (uint32_t)regReqMsg.threadNr, + (uint32_t)regReqMsg.regType, + (uint32_t)regReqMsg.numRegs); respHdr.setStatus( SBE_PRI_INVALID_DATA, SBE_SEC_GENERIC_FAILURE_IN_EXECUTION); break; @@ -223,7 +225,7 @@ uint32_t sbePutReg(uint8_t *i_pArg) if( fapiRc != FAPI2_RC_SUCCESS ) { SBE_ERROR(SBE_FUNC" ram_setup failed. threadNr:0x%x" - "chipletId:0x%02x", regReqMsg.threadNr, core); + "chipletId:0x%02x", (uint32_t)regReqMsg.threadNr, core); respHdr.setStatus( SBE_PRI_GENERIC_EXECUTION_FAILURE, SBE_SEC_GENERIC_FAILURE_IN_EXECUTION); ffdc.setRc(fapiRc); @@ -259,7 +261,8 @@ uint32_t sbePutReg(uint8_t *i_pArg) if( fapiRc ) { SBE_ERROR(SBE_FUNC" ram_cleanup failed. threadNr:0x%x" - " chipletId:0x%02x", regReqMsg.threadNr, core); + " chipletId:0x%02x", + (uint32_t)regReqMsg.threadNr, core); respHdr.setStatus( SBE_PRI_GENERIC_EXECUTION_FAILURE, SBE_SEC_GENERIC_FAILURE_IN_EXECUTION); ffdc.setRc(fapiRc); |
