Removing checkstop checks

* p9_sbe_chiplet_init
* p9_sbe_tp_chiplet_init3
* p9_mem_startclocks
* p9_sbe_common

Change-Id: I63c4f758b71cc16b9445ec6d5d0f404c10838c43
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29731
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Soma Bhanutej <soma.bhanu@in.ibm.com>
Reviewed-by: Sunil Kumar <skumar8j@in.ibm.com>
Reviewed-by: PARVATHI RACHAKONDA <prachako@in.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29735
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>

7 files changed, 3 insertions, 77 deletions

diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_chiplet_init.C b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_chiplet_init.C
index c832801c..98ef42ec 100644
--- a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_chiplet_init.C
+++ b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_chiplet_init.C
@@ -45,25 +45,12 @@
 fapi2::ReturnCode p9_sbe_chiplet_init(const
                                       fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target_chip)
 {
-    bool l_read_reg = false;
-    fapi2::buffer<uint64_t> l_data64;
     FAPI_INF("p9_sbe_chiplet_init: Entering..");
 
-    FAPI_DBG("Check  for XSTOP Bit");
-    //Getting INTERRUPT_TYPE_REG register value
-    FAPI_TRY(fapi2::getScom(i_target_chip, PERV_PIB_INTERRUPT_TYPE_REG, l_data64));
-    //l_read_reg = PIB.INTERRUPT_TYPE_REG.CHECKSTOP
-    l_read_reg = l_data64.getBit<2>();
-
-    FAPI_ASSERT(!(l_read_reg),
-                fapi2::CHECKSTOP_ERR()
-                .set_READ_CHECKSTOP(l_read_reg),
-                "ERROR:CHECKSTOP BIT GET SET ");
 
     FAPI_INF("p9_sbe_chiplet_init: Exiting ...");
 
-fapi_try_exit:
-    return fapi2::current_err;
+    return fapi2::FAPI2_RC_SUCCESS;
 
 }
 
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.C b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.C
index 46e9a4b6..bbdc3c67 100644
--- a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.C
+++ b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.C
@@ -282,31 +282,6 @@ fapi_try_exit:
 
 }
 
-/// @brief --check checkstop register
-/// @param[in]     i_target_chiplet   Reference to TARGET_TYPE_PERV target
-/// @return  FAPI2_RC_SUCCESS if success, else error code.
-fapi2::ReturnCode p9_sbe_common_check_checkstop_function(
-    const fapi2::Target<fapi2::TARGET_TYPE_PERV>& i_target_chiplet)
-{
-    fapi2::buffer<uint64_t> l_read_reg;
-    FAPI_INF("p9_sbe_common_check_checkstop_function: Entering ...");
-
-    FAPI_DBG("Check checkstop register");
-    //Getting XFIR register value
-    FAPI_TRY(fapi2::getScom(i_target_chiplet, PERV_XFIR,
-                            l_read_reg)); //l_read_reg = XFIR
-
-    FAPI_ASSERT(l_read_reg == 0,
-                fapi2::READ_ALL_CHECKSTOP_ERR()
-                .set_READ_ALL_CHECKSTOP(l_read_reg),
-                "ERROR: COMBINE ALL CHECKSTOP ERROR");
-
-    FAPI_INF("p9_sbe_common_check_checkstop_function: Exiting ...");
-
-fapi_try_exit:
-    return fapi2::current_err;
-
-}
 
 /// @brief check clocks status
 ///
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.H b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.H
index fbc93fe3..00838856 100644
--- a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.H
+++ b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_common.H
@@ -52,9 +52,6 @@ fapi2::ReturnCode p9_sbe_common_check_cc_status_function(
     const fapi2::buffer<uint16_t> i_regions,
     const fapi2::buffer<uint8_t> i_clock_types);
 
-fapi2::ReturnCode p9_sbe_common_check_checkstop_function(
-    const fapi2::Target<fapi2::TARGET_TYPE_PERV>& i_target_chiplet);
-
 fapi2::ReturnCode p9_sbe_common_check_status(const fapi2::buffer<uint64_t>
         i_regions,
         const fapi2::buffer<uint64_t> i_clock_status,
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tp_chiplet_init3.C b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tp_chiplet_init3.C
index f135733d..fe877144 100644
--- a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tp_chiplet_init3.C
+++ b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_tp_chiplet_init3.C
@@ -71,7 +71,6 @@ static fapi2::ReturnCode p9_sbe_tp_chiplet_init3_region_fence_setup(
 fapi2::ReturnCode p9_sbe_tp_chiplet_init3(const
         fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target_chip)
 {
-    bool l_read_reg = 0;
     fapi2::buffer<uint32_t> l_pfet_value;
     fapi2::buffer<uint32_t> l_attr_pfet;
     fapi2::buffer<uint64_t> l_regions;
@@ -191,17 +190,6 @@ fapi2::ReturnCode p9_sbe_tp_chiplet_init3(const
     l_data64.clearBit<6>();  //PERV.HANG_PULSE_5_REG.SUPPRESS_HANG_5 = 0b0
     FAPI_TRY(fapi2::putScom(i_target_chip, PERV_TP_HANG_PULSE_5_REG, l_data64));
 
-    FAPI_DBG("CHECK FOR XSTOP");
-    //Getting INTERRUPT_TYPE_REG register value
-    FAPI_TRY(fapi2::getScom(i_target_chip, PERV_PIB_INTERRUPT_TYPE_REG, l_data64));
-    //l_read_reg = PIB.INTERRUPT_TYPE_REG.CHECKSTOP
-    l_read_reg = l_data64.getBit<PERV_INTERRUPT_TYPE_REG_CHECKSTOP>();
-
-    FAPI_ASSERT(l_read_reg == 0,
-                fapi2::XSTOP_ERR()
-                .set_READ_XSTOP(l_read_reg),
-                "XSTOP BIT GET SET");
-
     FAPI_DBG("Start  calibration");
     //Setting KVREF_AND_VMEAS_MODE_STATUS_REG register value
     FAPI_TRY(fapi2::getScom(i_target_chip, PERV_TP_KVREF_AND_VMEAS_MODE_STATUS_REG, l_data64));
diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_chiplet_init_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_chiplet_init_errors.xml
index 1e7242c9..75b40730 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_chiplet_init_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_chiplet_init_errors.xml
@@ -27,12 +27,5 @@
 <!-- Halt codes for p9_sbe_chiplet_init -->
 
 <hwpErrors>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <sbeError/>
-    <rc>RC_CHECKSTOP_ERR</rc>
-    <description>Checkstop error after scan0</description>
-    <ffdc>READ_CHECKSTOP</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
+  
 </hwpErrors>
diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_common_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_common_errors.xml
index 1dfe8271..29c866d7 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_common_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_common_errors.xml
@@ -81,12 +81,5 @@
     <description>sl_thold status not matching the expected value in clock start stop sequence</description>
     <ffdc>READ_CLK_SL</ffdc>
   </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <sbeError/>
-    <rc>RC_READ_ALL_CHECKSTOP_ERR</rc>
-    <description>Read and or all Checkstop error</description>
-    <ffdc>READ_ALL_CHECKSTOP</ffdc>
-  </hwpError> 
-  <!-- ******************************************************************** -->
+  <!-- ******************************************************************** --> 
 </hwpErrors>
diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_tp_chiplet_init3_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_tp_chiplet_init3_errors.xml
index c4ad70fe..ecb9eea0 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_tp_chiplet_init3_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_tp_chiplet_init3_errors.xml
@@ -30,13 +30,6 @@
   <!-- ******************************************************************** -->
   <hwpError>
     <sbeError/>
-    <rc>RC_XSTOP_ERR</rc>
-    <description>Checkstop bit set in interrupt type reg</description>
-    <ffdc>READ_XSTOP</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <sbeError/>
     <rc>RC_CALIBRATION_NOT_DONE</rc>
     <description>Precision Reference Voltage : Calibration not done</description>
   </hwpError>