diff options
author | Claus Michael Olsen <cmolsen@us.ibm.com> | 2016-10-19 21:20:45 -0500 |
---|---|---|
committer | spashabk-in <shakeebbk@in.ibm.com> | 2016-12-20 05:18:56 -0600 |
commit | 1a3a8543f8c589f8f1ecb633798096e1d21417b0 (patch) | |
tree | 20abde6fdbbd1d74521dbf86cfe1639cadb39895 /src/import/tools | |
parent | 6d78d6dc0ac045932e815ab2e6646ca40b46d701 (diff) | |
download | talos-sbe-1a3a8543f8c589f8f1ecb633798096e1d21417b0.tar.gz talos-sbe-1a3a8543f8c589f8f1ecb633798096e1d21417b0.zip |
TOR reduction: Ditching DeltaRingLayout and RingLayout_t
- Complete overhaul of get_ring_from_sbe_image for improved clarity
in effort to remove anything related to 8Byte RingLayout header,
incl built-in and hardcoded assumptions.
- Functional overhaul of get_ring_from_cme/sgpe_image, but only
slight improvement in clarity. Also removed any traces of
RingLayout assumptions. (Beautification of these functions
will be in separate commit.)
- Overhaul of tor_append_ring for clarity and improved clarity
elsewhere where PUT_SINGLE_RING is used.
- Updated p9_tor.C|H in order to expose version 2 of TOR API,
which eliminates the 8B RingLayout structure, in order to
work with Cronus which currently assumes, due to pulling in
the p9_tor.H header file, that RingLayout structure is being
used.
- Updated p9_scan_compression.C to remove most zero padding at end
of compressed ring (i.e., merged commit 32647 into this commit
in order to be able to merge into gerrit).
- The scan compression code used to pad the compressed ring at its
end with zeros up to the next 8 byte boundary. For P9, no
padding is needed. Most of this padding is now removed, just
keeping a padding to the next 2 byte boundary for convenience.
Removal of these padding bytes saves about 400 bytes in SEEPROM.
- Added p9_ipl_build.C because it assumes an 8B alignment of the
SBE ring block which is no longer the case with RS4v3. We've
been lucky so far in our tests.
Change-Id: I08edef8e53302dab765a73dc4d6ca68cd8dce440
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31524
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32268
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src/import/tools')
-rw-r--r-- | src/import/tools/imageProcs/p9_ipl_build.C | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/import/tools/imageProcs/p9_ipl_build.C b/src/import/tools/imageProcs/p9_ipl_build.C index 495d17ce..61139e36 100644 --- a/src/import/tools/imageProcs/p9_ipl_build.C +++ b/src/import/tools/imageProcs/p9_ipl_build.C @@ -310,7 +310,8 @@ int ipl_build( char* i_fnSbeImage, if(rc == IMGBUILD_SUCCESS) { // update our SBE image size to include the new block of rings - sbeImageSize += l_blockSize; + // and make sure it's 8 byte aligned + sbeImageSize += ((l_blockSize + 7) / 8) * 8; // grow our workspace void* tmp = realloc(sbeImage, sbeImageSize); |