diff options
author | spashabk-in <shakeebbk@in.ibm.com> | 2018-08-13 02:33:28 -0500 |
---|---|---|
committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2018-09-21 06:12:53 -0500 |
commit | e1a4637ad7c4f86f456f15ea538823db60287b78 (patch) | |
tree | b373b3c1a38beb8368b9e7644af67c3cb0aaeff5 /src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C | |
parent | 26acfd0fd5e7df0053336bd8ee1baba9e1e926dc (diff) | |
download | talos-sbe-e1a4637ad7c4f86f456f15ea538823db60287b78.tar.gz talos-sbe-e1a4637ad7c4f86f456f15ea538823db60287b78.zip |
Support 1byte data access on LPC
Currently LPC driver supports only 4bytes data access,
with this commit introducing support for 1byte and
also a way to extend this to 2bytes.
RTC: 194000
Change-Id: I7cb258425100c2d2a3e78f35f0aaf7da1c0e8508
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64174
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Joachim Fenkes <fenkes@de.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RAJA DAS <rajadas2@in.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64176
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C b/src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C index a3e6bd18..af1e5e3b 100644 --- a/src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C +++ b/src/import/chips/p9/procedures/hwp/perv/p9_lpc_utils.C @@ -32,21 +32,22 @@ fapi2::ReturnCode lpc_rw( const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target_chip, const uint32_t i_addr, + const size_t i_size, const bool i_read_notwrite, const bool i_generate_ffdc, fapi2::buffer<uint32_t>& io_data) { - const int l_bit_offset = (i_addr & 4) << 3; fapi2::buffer<uint64_t> l_command; + const int l_bit_offset = (i_addr & 7 & ~(i_size - 1)) << 3; l_command.writeBit<PU_LPC_CMD_REG_RNW>(i_read_notwrite) - .insertFromRight<PU_LPC_CMD_REG_SIZE, PU_LPC_CMD_REG_SIZE_LEN>(0x4) + .insertFromRight<PU_LPC_CMD_REG_SIZE, PU_LPC_CMD_REG_SIZE_LEN>(i_size) .insertFromRight<PU_LPC_CMD_REG_ADR, PU_LPC_CMD_REG_ADR_LEN>(i_addr); FAPI_TRY(fapi2::putScom(i_target_chip, PU_LPC_CMD_REG, l_command), "Error writing LPC command register"); if (!i_read_notwrite) { fapi2::buffer<uint64_t> l_data; - l_data.insert(io_data, l_bit_offset, 32); + l_data.insert(io_data, l_bit_offset, 8 * i_size); FAPI_TRY(fapi2::putScom(i_target_chip, PU_LPC_DATA_REG, l_data), "Error writing LPC data"); } @@ -86,7 +87,7 @@ fapi2::ReturnCode lpc_rw( { fapi2::buffer<uint64_t> l_data; FAPI_TRY(fapi2::getScom(i_target_chip, PU_LPC_DATA_REG, l_data), "Error reading LPC data"); - l_data.extract(io_data, l_bit_offset, 32); + l_data.extract(io_data, l_bit_offset, 8 * i_size); } return fapi2::FAPI2_RC_SUCCESS; |