diff options
| author | Doug Gilbert <dgilbert@us.ibm.com> | 2016-10-13 13:59:53 -0500 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2016-11-23 23:14:54 -0500 |
| commit | 4d9e06f89702dd907a209b0ce9cb9fa36858d8cd (patch) | |
| tree | 8cce47a1c23de9dd67788f732027b3b031e342ce /src/hwpf | |
| parent | 24f6d36ca47af190b6246d22401805ffd2df7c2a (diff) | |
| download | talos-sbe-4d9e06f89702dd907a209b0ce9cb9fa36858d8cd.tar.gz talos-sbe-4d9e06f89702dd907a209b0ce9cb9fa36858d8cd.zip | |
Fix some trace problems
This change is in preparation for future, better trace handling.
Bit fields don't have a size_type - so they need a cast to int or uint in a
trace statement.
Pointers are always 4 bytes in PPE.
Pointers cannot be converted to a uint32_t (%x) without an explicit cast.
The printf/trace format %x is 4 bytes, even %016x is 4 bytes. What is
needed is %llx or %016llx otherise a uint64_t will get truncated.
Change-Id: I0b55a355f3211a7f6913e846834486b4808f50c1
RTC: 161851
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31189
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src/hwpf')
| -rw-r--r-- | src/hwpf/src/plat_ring_traverse.C | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/hwpf/src/plat_ring_traverse.C b/src/hwpf/src/plat_ring_traverse.C index f93e566d..0c7c8df9 100644 --- a/src/hwpf/src/plat_ring_traverse.C +++ b/src/hwpf/src/plat_ring_traverse.C @@ -387,7 +387,7 @@ fapi2::ReturnCode getRS4ImageFromTor( uint32_t *l_sectionAddr = reinterpret_cast<uint32_t *>(g_seepromAddr + i_sectionOffset + l_sectionOffset); - SBE_TRACE ("l_sectionAddr %08X",l_sectionAddr); + SBE_TRACE ("l_sectionAddr %08X",(uint32_t)l_sectionAddr); uint16_t *l_ringTorAddr = NULL; @@ -431,7 +431,7 @@ fapi2::ReturnCode getRS4ImageFromTor( // 3. Risk Level - SBE_TRACE ("ring tor address %04X\n",l_ringTorAddr); + SBE_TRACE ("ring tor address %08X\n",(uint32_t)l_ringTorAddr); // If there are non-base variants of the ring, we'll have to check // attributes to determine the sequence of ring apply. @@ -468,7 +468,7 @@ fapi2::ReturnCode getRS4ImageFromTor( uint8_t *l_addr = reinterpret_cast<uint8_t *>(l_sectionAddr); uint8_t *l_rs4Address = reinterpret_cast<uint8_t *> (l_addr + *l_ringTorAddr); - SBE_TRACE("l_rs4Address %08x",l_rs4Address); + SBE_TRACE("l_rs4Address %08x",(uint32_t)l_rs4Address); l_rc = rs4DecompressionSvc(i_target,l_rs4Address, i_applyOverride,i_ringMode,l_ringType); if(l_rc != fapi2::FAPI2_RC_SUCCESS) |
