diff options
| author | Prem Shanker Jha <premjha2@in.ibm.com> | 2017-01-11 03:50:31 -0600 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2017-03-09 00:30:39 -0500 |
| commit | a13395365d0bfbadfe4709439d83143e6bd6f691 (patch) | |
| tree | 2cc5a75476828d8469d0eda9e4ebe6c9d2513848 | |
| parent | c25169e141cdc2654958a427e10c1e5847b450b3 (diff) | |
| download | talos-sbe-a13395365d0bfbadfe4709439d83143e6bd6f691.tar.gz talos-sbe-a13395365d0bfbadfe4709439d83143e6bd6f691.zip | |
PM: Addressed various observations on Hcode Image Build
Commit ensures a bad return code when :
- attribute used is not available
- hw image has no scan rings
- image size check fails
In many cases it was just producing an error trace.
CMVC-Prereq: 1018118
Change-Id: Ia67964e46af7251b45bbd192a8fcb78274c17353
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34710
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: AMIT KUMAR <akumar3@us.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35213
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
| -rw-r--r-- | src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml index 86e1b374..a76bb9e2 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml @@ -267,7 +267,7 @@ Valid range: 500KHz to 2500KHz - Consumer: p8_pss_init + Consumer: p9_pss_init Overridden by the Machine Readable Workbook. @@ -1534,17 +1534,17 @@ </attribute> <!-- ********************************************************************* --> <attribute> - <id>ATTR_SYSTEM_RING_DBG_MODE</id> - <description> - Debug modes supported for CME/SGPE Scan layout in HOMER. - </description> - <targetType>TARGET_TYPE_SYSTEM</targetType> - <valueType>uint8</valueType> - <enum> - SCAN_RING_NO_DEBUG = 0x00, SCAN_RING_TRACE_DEBUG = 0x01 - </enum> - <initToZero/> - <platInit/> + <id>ATTR_SYSTEM_RING_DBG_MODE</id> + <description> + Debug modes supported for CME/SGPE Scan layout in HOMER. + </description> + <targetType>TARGET_TYPE_SYSTEM</targetType> + <valueType>uint8</valueType> + <enum> + SCAN_RING_NO_DEBUG = 0x00, SCAN_RING_TRACE_DEBUG = 0x01, SCAN_RING_DEEP_DEBUG = 0x02 + </enum> + <initToZero/> + <platInit/> </attribute> <!-- ********************************************************************* --> <attribute> |
