path: root/lib
diff options
authorSamuel Mendoza-Jonas <>2017-01-25 14:45:37 +1100
committerSamuel Mendoza-Jonas <>2017-03-15 16:30:13 +1100
commitd0602ed25e3bff8298c19bece8cd8b3f80d86624 (patch)
tree10ecded0c7aa51f31662a811866c943082cb8e6a /lib
parent63271b068064caea5f148f6bd6728adabef5cf87 (diff)
discover: Track both configured and current autoboot settings
If autoboot is enabled but later disabled or cancelled by, for example, an IPMI override then the nc-config screen will set the autoboot widget as disabled. If the user then makes and saves a change in nc-config, autoboot will also be saved as disabled. This accidental change is particularly awkward if the user is attempting to remove an IPMI override. Instead only ever change the autoboot setting if the user explicitly changes it. Use a new helper function 'config_autoboot_active()' to determine the current autoboot status where needed. Signed-off-by: Samuel Mendoza-Jonas <>
Diffstat (limited to 'lib')
2 files changed, 14 insertions, 0 deletions
diff --git a/lib/types/types.c b/lib/types/types.c
index 63045e1..d7f4ead 100644
--- a/lib/types/types.c
+++ b/lib/types/types.c
@@ -75,3 +75,15 @@ enum device_type find_device_type(const char *str)
+bool config_autoboot_active(const struct config *config)
+ enum ipmi_bootdev bootdev = config->ipmi_bootdev;
+ if (!config->autoboot_enabled)
+ return false;
+ if (bootdev == IPMI_BOOTDEV_SETUP || bootdev == IPMI_BOOTDEV_SAFE)
+ return false;
+ return true;
diff --git a/lib/types/types.h b/lib/types/types.h
index 13ff7fc..7f4ae1f 100644
--- a/lib/types/types.h
+++ b/lib/types/types.h
@@ -183,4 +183,6 @@ struct config {
bool debug;
+bool config_autoboot_active(const struct config *config);
#endif /* _TYPES_H */
OpenPOWER on IntegriCloud