summaryrefslogtreecommitdiffstats
path: root/meta-openbmc-machines
diff options
context:
space:
mode:
authorAndrew Jeffery <andrew@aj.id.au>2017-02-06 13:00:57 +1030
committerPatrick Williams <patrick@stwcx.xyz>2017-02-09 17:32:13 +0000
commit092f506b45d5e3108902b8f01784eb9ac6bab5b7 (patch)
treefc43eac104df9deca0dadc86ba63e6eb6dc929f9 /meta-openbmc-machines
parent0fbda6cd06a553ad2a4896066002d2eae9cc8e65 (diff)
downloadtalos-openbmc-092f506b45d5e3108902b8f01784eb9ac6bab5b7.tar.gz
talos-openbmc-092f506b45d5e3108902b8f01784eb9ac6bab5b7.zip
mboxd: Use escaped unit names for device dependencies
Inspecting the journal showed that the device units that mboxd depends on were timing out: Jan 30 02:48:29 witherspoon systemd[1]: Timed out waiting for device dev-aspeed-lpc-ctrl.device. Jan 30 02:48:29 witherspoon systemd[1]: dev-aspeed-lpc-ctrl.device: Job dev-aspeed-lpc-ctrl.device/start failed with result 'timeout'. Jan 30 02:48:29 witherspoon systemd[1]: dev-aspeed-mbox.device: Job dev-aspeed-mbox.device/start timed out. Jan 30 02:48:29 witherspoon systemd[1]: Timed out waiting for device dev-aspeed-mbox.device. Jan 30 02:48:29 witherspoon systemd[1]: dev-aspeed-mbox.device: Job dev-aspeed-mbox.device/start failed with result 'timeout' As it turns out, systemd wants escaped strings to cope with e.g. paths with dashes in the filename. Update the Wants/After lines to use the escaped strings. The escaped values were created running `systemd-escape`[1] on a Zaius image under QEMU: root@zaius:~# systemd-escape -p /dev/aspeed-* dev-aspeed\x2dlpc\x2dctrl dev-aspeed\x2dmbox This leaves us with the happy result of no timeouts: # journalctl | grep aspeed ... Feb 06 02:25:22 zaius systemd[1]: Found device /dev/aspeed-mbox. Feb 06 02:25:25 zaius systemd[1]: Found device /dev/aspeed-lpc-ctrl. ... [1] https://www.freedesktop.org/software/systemd/man/systemd-escape.html# Change-Id: I4770026842757768b20b919125af47ae499d1667 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Diffstat (limited to 'meta-openbmc-machines')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud