summaryrefslogtreecommitdiffstats
path: root/sound/soc/sof/topology.c
diff options
context:
space:
mode:
authorJaroslav Kysela <perex@perex.cz>2020-01-22 20:07:52 +0100
committerMark Brown <broonie@kernel.org>2020-01-23 12:11:11 +0000
commit8ce1cbd6ce0b1bda0c980c64fee4c1e1378355f1 (patch)
treef9a3e9eee0b78ac068a65bd376f7cc9faba727ac /sound/soc/sof/topology.c
parent15adb20f64c302b31e10ad50f22bb224052ce1df (diff)
downloadtalos-op-linux-8ce1cbd6ce0b1bda0c980c64fee4c1e1378355f1.tar.gz
talos-op-linux-8ce1cbd6ce0b1bda0c980c64fee4c1e1378355f1.zip
ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order
The code which checks the return value for snd_soc_add_dai_link() call in soc_tplg_fe_link_create() moved the snd_soc_add_dai_link() call before link->dobj members initialization. While it does not affect the latest kernels, the old soc-core.c code in the stable kernels is affected. The snd_soc_add_dai_link() function uses the link->dobj.type member to check, if the link structure is valid. Reorder the link->dobj initialization to make things work again. It's harmless for the recent code (and the structure should be properly initialized before other calls anyway). The problem is in stable linux-5.4.y since version 5.4.11 when the upstream commit 76d270364932 was applied. Fixes: 76d270364932 ("ASoC: topology: Check return value for snd_soc_add_dai_link()") Cc: Dragos Tarcatu <dragos_tarcatu@mentor.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Cc: Mark Brown <broonie@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz> Link: https://lore.kernel.org/r/20200122190752.3081016-1-perex@perex.cz Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/topology.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud