summaryrefslogtreecommitdiffstats
path: root/net/switchdev
diff options
context:
space:
mode:
authorSteven Rostedt (VMware) <rostedt@goodmis.org>2018-07-02 11:41:38 -0400
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2018-07-03 18:14:40 -0400
commitf90658725ba7ebb031054866aff4cda0d099a3b1 (patch)
treefeafdd5734022a3ae1975a9e85065ee53a272c6e /net/switchdev
parentcf4d418e653afc84c9c873236033e06be5d58f1c (diff)
downloadtalos-op-linux-f90658725ba7ebb031054866aff4cda0d099a3b1.tar.gz
talos-op-linux-f90658725ba7ebb031054866aff4cda0d099a3b1.zip
tracing: Make create_filter() code match the comments
The comment in create_filter() states that the passed in filter pointer (filterp) will either be NULL or contain an error message stating why the filter failed. But it also expects the filter pointer to point to NULL when passed in. If it is not, the function create_filter_start() will warn and return an error message without updating the filter pointer. This is not what the comment states. As we always expect the pointer to point to NULL, if it is not, trigger a WARN_ON(), set it to NULL, and then continue the path as the rest will work as the comment states. Also update the comment to state it must point to NULL. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'net/switchdev')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud