diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2014-04-28 10:49:43 +0000 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2014-04-30 10:34:39 +0530 |
commit | cdae05a0f0f7d15837dfd6f4200e8caea03c9cbf (patch) | |
tree | 9513241fb0020ad9cbd0b2e2fa36f707e09b864b /include/linux/range.h | |
parent | c2da2340e5818aa72b2e847f1f24b036742ea5c7 (diff) | |
download | talos-op-linux-cdae05a0f0f7d15837dfd6f4200e8caea03c9cbf.tar.gz talos-op-linux-cdae05a0f0f7d15837dfd6f4200e8caea03c9cbf.zip |
dmaengine: edma: Make reading the position of active channels work
As Joel pointed out, edma_read_position() uses memcpy_fromio() to read
the parameter ram. That's not synchronized with the internal update as
it does a byte by byte copy. We need to do a 32bit read to get a
consistent value.
Further reading destination and source is pointless. In DEV_TO_MEM
transfers we are only interested in the destination, in MEM_TO_DEV we
care about the source. In MEM_TO_MEM it really does not matter which
one you read.
Simple solution: Remove the pointers, select dest/source via a bool
and return the read value.
Remove the export of this function while at it. The only potential
user is the dmaengine and that's always builtin.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Joel Fernandes <joelf@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/linux/range.h')
0 files changed, 0 insertions, 0 deletions