diff options
| author | Dan Carpenter <error27@gmail.com> | 2011-05-29 22:56:31 +0300 |
|---|---|---|
| committer | Joel Becker <jlbec@evilplan.org> | 2011-05-31 19:03:44 -0700 |
| commit | 3d75be7c4771c7e4d5b5fa586a599af8473de32c (patch) | |
| tree | 45052c6e7317f1bfe2d0f6961ca5a738deae5766 /fs | |
| parent | 03efed8a2a1b8e00164eb4720a82a7dd5e368a8e (diff) | |
| download | talos-op-linux-3d75be7c4771c7e4d5b5fa586a599af8473de32c.tar.gz talos-op-linux-3d75be7c4771c7e4d5b5fa586a599af8473de32c.zip | |
ocfs2: checking the wrong variable in ocfs2_move_extent()
"new_phys_cpos" is always a valid pointer here.
ocfs2_probe_alloc_group() allocates "*new_phys_cpos".
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Joel Becker <jlbec@evilplan.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ocfs2/move_extents.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c index cd9427023d2e..d3433d60dbb9 100644 --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c @@ -746,7 +746,7 @@ static int ocfs2_move_extent(struct ocfs2_move_extents_context *context, */ ocfs2_probe_alloc_group(inode, gd_bh, &goal_bit, len, move_max_hop, new_phys_cpos); - if (!new_phys_cpos) { + if (!*new_phys_cpos) { ret = -ENOSPC; goto out_commit; } |
