diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-08-27 12:23:01 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-08-27 13:17:00 -0400 |
| commit | b9eb3b14f1dbf16bf27b6c1ffe6b8c00ec945c9b (patch) | |
| tree | f57ec77420c75bcde93949359dd01b3e762fb6b5 /drivers/scsi/aacraid | |
| parent | d772a65d8a6c45c376a8200a38f7f82fb480af6a (diff) | |
| download | talos-op-linux-b9eb3b14f1dbf16bf27b6c1ffe6b8c00ec945c9b.tar.gz talos-op-linux-b9eb3b14f1dbf16bf27b6c1ffe6b8c00ec945c9b.zip | |
scsi: aacraid: fix a signedness bug
The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.
[mkp: fixed typo]
Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/aacraid')
| -rw-r--r-- | drivers/scsi/aacraid/aacraid.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 29bf1e60f542..39eb415987fc 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h @@ -1346,7 +1346,7 @@ struct fib { struct aac_hba_map_info { __le32 rmw_nexus; /* nexus for native HBA devices */ u8 devtype; /* device type */ - u8 reset_state; /* 0 - no reset, 1..x - */ + s8 reset_state; /* 0 - no reset, 1..x - */ /* after xth TM LUN reset */ u16 qd_limit; u32 scan_counter; |
