summaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-coh901331.c
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2018-03-30 14:16:06 -0500
committerBjorn Helgaas <bhelgaas@google.com>2018-05-25 17:29:49 -0500
commit57d12fc6f78889677ec49d049fcec35ef8a03c53 (patch)
tree0864c35773a29a44e2b5f21ae6a96ae5122693b9 /drivers/rtc/rtc-coh901331.c
parentaf125b754e2f09e6061e65db8f4eda0f7730011d (diff)
downloadtalos-op-linux-57d12fc6f78889677ec49d049fcec35ef8a03c53.tar.gz
talos-op-linux-57d12fc6f78889677ec49d049fcec35ef8a03c53.zip
cxgb4: Report PCIe link properties with pcie_print_link_status()
Previously the driver used pcie_get_minimum_link() to warn when the NIC is in a slot that can't supply as much bandwidth as the NIC could use. pcie_get_minimum_link() can be misleading because it finds the slowest link and the narrowest link (which may be different links) without considering the total bandwidth of each link. For a path with a 16 GT/s x1 link and a 2.5 GT/s x16 link, it returns 2.5 GT/s x1, which corresponds to 250 MB/s of bandwidth, not the true available bandwidth of about 1969 MB/s for a 16 GT/s x1 link. Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. This finds the slowest link in the path to the device by computing the total bandwidth of each link and compares that with the capabilities of the device. The dmesg change is: - PCIe link speed is %s, device supports %s - PCIe link width is x%d, device supports x%d + %u.%03u Gb/s available PCIe bandwidth (%s x%d link) or, if the device is capable of better performance than is available in the current slot: - A slot with more lanes and/or higher speed is suggested for optimal performance. + %u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link) Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/rtc/rtc-coh901331.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud